Bug 1734136: aws/defaults/platform: Default to m5 in ap-east-1 #2108
Conversation
The Hong Kong region is new 2019-04-25 and does not support the older m4 types [1]. This pull-request adds it (commented out in validation, because we don't push RHCOS AMIs there). It also expands the seeded regions in TestGetDefaultInstanceClass to gets the tests to pass: platformtests/aws$ AWS_PROFILE=openshift-dev go test . ok github.com/openshift/installer/platformtests/aws 26.282s [1]: https://aws.amazon.com/blogs/aws/now-open-aws-asia-pacific-hong-kong-region/
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Not referenced directly by rhbz#1725524, but we need to backport #1755 to avoid this conflict when backporting #1935. |
wking
changed the title
|
@openshift-cherrypick-robot: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retitle [release-4.1] aws/defaults/platform: Default to m5 in ap-east-1 This bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1725524 doesn't seem to belong to changeset. /bugzilla refresh |
openshift-ci-robot
changed the title
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/valid-bug
|
@abhinavdahiya: This pull request references a valid Bugzilla bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retitle Bug 1734136: aws/defaults/platform: Default to m5 in ap-east-1 We now have an ap-east-1-specific 4.1.z bug, so reference it. |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/invalid-bug
|
@openshift-cherrypick-robot: This pull request references an invalid Bugzilla bug:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We're not planning on supporting ap-east-1 in 4.1.z. /close |
|
@wking: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This is an automated cherry-pick of #1755
/assign wking