aws/defaults/platform: Default to m5 in ap-east-1 #1755
Conversation
The Hong Kong region is new 2019-04-25 and does not support the older m4 types [1]. This pull-request adds it (commented out in validation, because we don't push RHCOS AMIs there). It also expands the seeded regions in TestGetDefaultInstanceClass to gets the tests to pass: platformtests/aws$ AWS_PROFILE=openshift-dev go test . ok github.com/openshift/installer/platformtests/aws 26.282s [1]: https://aws.amazon.com/blogs/aws/now-open-aws-asia-pacific-hong-kong-region/
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
/test e2e-openstack |
abhinavdahiya
changed the title
I suspect it'd be nearly as fast for us to just copy AMIs from another region as to have it pre-uploaded. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.1 We need this so #1935 can be backported cleanly. |
|
@wking: new pull request created: #2108 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think the bar for entry to release-4.1 is higher than need this for clean cherry-pick, all PRs in t release-4.1 need a bug and approval from Architects (or more) I would rather suggest we backport manually.. |
I agree in theory, but this is the same issue as #1935, right? If #1935 passes the bar, then why wouldn't this PR pass that same bar? On the other hand, we'd also be internally consistent saying that neither this PR nor #1935 passes the 4.1.z bar, and closing rhbz#1725524 as WONTFIX for 4.1.z. |
|
I'm not saying this PR doesn't meet the bar for release-4.1 but the reason this needs to be backported cannot be "needs by another PR for backport" |
So how do you feel about expanding the scope of rhbz#1725524 to include ap-east-1? |
|
I think we can create another one for ap-east-1 and get both in individually serially |
AWS allows m4 class for reserved instances in all AZs for ap-northeast-2 ```console aws --region ap-northeast-2 ec2 describe-reserved-instances-offerings --instance-tenancy default --instance-type m4.large --product-description 'Linux/UNIX' --filters Name=scope,Values='Availability Zone' | jq -r '[.ReservedInstancesOfferings[].AvailabilityZone] | sort | unique[]' ap-northeast-2a ap-northeast-2b ap-northeast-2c ``` But the on-demand instances in ap-norteast-2b was failing with error ``` Unsupported: Your requested instance type (m4.xlarge) is not supported in your requested Availability Zone (ap-northeast-2b). Please retry your request by not specifying an Availability Zone or choosing ap-northeast-2a, ap-northeast-2c. ``` So moving to m5 class for ap-northeast-2 should allow creating control plane instances in all Zones. (the default configuration) This commit cherry-picks 3085753 (Bug 1725524: types/aws/default: move ap-northeast-2 to m5 instance class, 2019-07-02, openshift#1935). It's not a clean cherry-pick, because we decided to not backport the ap-east-1 addition from cdd6689 (pkg/types/aws/defaults/platform: Default to m5 in ap-east-1, 2019-05-16, openshift#1755) to 4.1.z [1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1734136#c4
7 participants
The Hong Kong region is new 2019-04-25 and does not support the older m4 types. This pull-request adds it (commented out in validation, because we don't push RHCOS AMIs there, see also #1528). It also expands the seeded regions in
TestGetDefaultInstanceClassto gets the tests to pass: