Skip to content

data/data/openstack: Open UDP 5353 (mdns) port #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 1, 2019
Merged

data/data/openstack: Open UDP 5353 (mdns) port #1925

openshift-merge-robot merged 1 commit into from
Jul 1, 2019

Conversation

@tomassedovic
Copy link
Contributor

@tomassedovic tomassedovic commented Jul 1, 2019

The mdns port is going to be used for updating the internal DNS
records necessary for the installation to succeed (the master & etcd A
as well as the SRV records).

Some OpenStack deployments allow UDP traffic by default, but some
don't so we need to create this Security Group Rule explicitly.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2019
@tomassedovic
Copy link
Contributor Author

tomassedovic commented Jul 1, 2019

/assign @mandre

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2019
@tomassedovic tomassedovic mentioned this pull request Jul 1, 2019
Closed
@tomassedovic
Copy link
Contributor Author

tomassedovic commented Jul 1, 2019

Related (but not blocking) PRs:

openshift/machine-config-operator#740
#1746

@mandre
Copy link
Member

mandre commented Jul 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@tomassedovic
data/data/openstack: Open UDP 5353 (mdns) port
853ed3e 
The mdns port is going to be used for updating the internal DNS
records necessary for the installation to succeed (the master & etcd A
as well as the SRV records).

Some OpenStack deployments allow UDP traffic by default, but some
don't so we need to create this Security Group Rule explicitly.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2019
@tomassedovic
Copy link
Contributor Author

tomassedovic commented Jul 1, 2019

/retest

@trown
Copy link

trown commented Jul 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, tomassedovic, trown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tomassedovic
Copy link
Contributor Author

tomassedovic commented Jul 1, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit fd08f44 into openshift:master Jul 1, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 1, 2019

@tomassedovic: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 853ed3e link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tomassedovic tomassedovic deleted the openstack-mdns-sg branch July 2, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@mandre mandre

@trown trown

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tomassedovic @mandre @openshift-bot @trown @openshift-ci-robot @openshift-merge-robot