openstack: remove SRV records from service VM #1746
Conversation
openshift-ci-robot
added
the
size/M
|
/hold we need to merge openshift/machine-config-operator#740 first |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trown The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
This is part of the work to remove the service VM from the openstack architecture. This relies on the coredns/mdns static pods setup in: openshift/machine-config-operator/pull/740
|
@trown: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
tomassedovic
left a comment
tomassedovic
left a comment
There was a problem hiding this comment.
Looks great, but it needs an extra security group rule for envs that block UDP by default.
Happy to merge it afterwards (once the MOC PR lands).
| remote_ip_prefix = "${var.cidr_block}" | ||
| security_group_id = "${openstack_networking_secgroup_v2.master.id}" | ||
| } | ||
|
|
There was a problem hiding this comment.
I've got two separate OpenStack deployments where any UDP traffic is blocked by default. That means the mDNS messages are never received and each master is left without the DNS records for the other masters.
Adding this rule (5353 is the port used to send the update messages) got me to a successful deployment on both OpenStack envs:
resource "openstack_networking_secgroup_rule_v2" "master_ingress_mdns_udp" {
direction = "ingress"
ethertype = "IPv4"
protocol = "udp"
port_range_min = 5353
port_range_max = 5353
remote_ip_prefix = "${var.cidr_block}"
security_group_id = "${openstack_networking_secgroup_v2.master.id}"
}There was a problem hiding this comment.
I've created a separate PR for that here:
openshift-ci-robot
added
the
needs-rebase
|
@trown: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
closing due to inactivity. Please reopen if needed. /close |
|
@abhinavdahiya: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This is part of the work to remove the service VM from the
openstack architecture. This relies on the coredns/mdns static
pods setup in: openshift/machine-config-operator/pull/740