machines/azure: Set subnets for control plane and compute machines

[abhinavdahiya]

With changes in the cluster-api-provider-azure from openshift/cluster-api-provider-azure#35, the Azure IPI fails to create worker VMs like
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_release/4006/rehearse-4006-pull-ci-openshift-origin-master-e2e-azure/1/artifacts/e2e-azure/must-gather/namespaces/openshift-machine-api/pods/machine-api-controllers-c95fb75b5-rzjks/machine-controller/machine-controller/logs/current.log

2019-06-07T19:38:06.7703507Z E0607 19:38:06.770317       1 actuator.go:79] failed to reconcile machine ci-op-pqj0zh18-849ce-9765f-worker-qg7fj: failed to create nic ci-op-pqj0zh18-849ce-9765f-worker-qg7fj-nic for machine ci-op-pqj0zh18-849ce-9765f-worker-qg7fj: MachineConfig subnet is missing on machine ci-op-pqj0zh18-849ce-9765f-worker-qg7fj, skipping machine creation

This changes the installer to set the subnet names based on the role of the MachinePool.

/cc @enxebre @ingvagabund

[abhinavdahiya]

/test e2e-azure

[ingvagabund]

/test e2e-azure

[ingvagabund]

@abhinavdahiya #35 also removed pieces setting load balancers. Was installer relying on azure actuator to set the load balancers when creating master machine(s)?

[ingvagabund]

/retest

[ingvagabund]

/test e2e-azure

[ingvagabund]

/test e2e-azure

[ingvagabund]

Repeated in a loop in openshift-machine-api_machine-api-controllers-7d7675558d-sk6r9_machine-controller.log:

I0612 21:08:32.957058       1 controller.go:129] Reconciling Machine "ci-op-qdxjy6fw-2dc90-vcspv-worker-2x6st"
I0612 21:08:32.957089       1 controller.go:298] Machine "ci-op-qdxjy6fw-2dc90-vcspv-worker-2x6st" in namespace "openshift-machine-api" doesn't specify "cluster.k8s.io/cluster-name" label, assuming nil cluster
I0612 21:08:32.957100       1 actuator.go:146] Checking if machine ci-op-qdxjy6fw-2dc90-vcspv-worker-2x6st exists
E0612 21:08:32.957527       1 controller.go:233] Failed to check if machine "ci-op-qdxjy6fw-2dc90-vcspv-worker-2x6st" exists: failed to create scope: Secret "azure-credentials" not found
failed to update cluster
sigs.k8s.io/cluster-api-provider-azure/pkg/cloud/azure/actuators.NewMachineScope
	/go/src/sigs.k8s.io/cluster-api-provider-azure/pkg/cloud/azure/actuators/machine_scope.go:86
sigs.k8s.io/cluster-api-provider-azure/pkg/cloud/azure/actuators/machine.(*Actuator).Exists
	/go/src/sigs.k8s.io/cluster-api-provider-azure/pkg/cloud/azure/actuators/machine/actuator.go:148
sigs.k8s.io/cluster-api-provider-azure/vendor/github.com/openshift/cluster-api/pkg/controller/machine.(*ReconcileMachine).Reconcile
	/go/src/sigs.k8s.io/cluster-api-provider-azure/vendor/github.com/openshift/cluster-api/pkg/controller/machine/controller.go:231
sigs.k8s.io/cluster-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/src/sigs.k8s.io/cluster-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:210
sigs.k8s.io/cluster-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
	/go/src/sigs.k8s.io/cluster-api-provider-azure/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158
sigs.k8s.io/cluster-api-provider-azure/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
	/go/src/sigs.k8s.io/cluster-api-provider-azure/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152
sigs.k8s.io/cluster-api-provider-azure/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/src/sigs.k8s.io/cluster-api-provider-azure/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153
sigs.k8s.io/cluster-api-provider-azure/vendor/k8s.io/apimachinery/pkg/util/wait.Until
	/go/src/sigs.k8s.io/cluster-api-provider-azure/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:2361

[ingvagabund]

/test e2e-azure

[ingvagabund]

/test e2e-azure

[abhinavdahiya]

Looks like last run of azure failed where we expected.
Networking should provide Internet connection for containers [Feature:Networking-IPv4] [Suite:openshift/conformance/parallel] [Suite:k8s] expand_more

e2e-azure

[ingvagabund]

@abhinavdahiya I assume it's a known issue, so we can merge this PR

[abhinavdahiya]

@abhinavdahiya I assume it's a known issue, so we can merge this PR

Yes that a known failure, that I'm working on fixing. We can merge this.

[ingvagabund]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ingvagabund]

/test e2e-azure

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@abhinavdahiya: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure	b29f9da	link	/test e2e-azure
ci/prow/e2e-aws-scaleup-rhel7	b29f9da	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.