-
Notifications
You must be signed in to change notification settings - Fork 1.5k
asset/password: KubeadminPassword responsible for the password file #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asset/password: KubeadminPassword responsible for the password file #1539
Conversation
|
|
|
/lgtm |
|
/hold until you've deleted the busted project. |
|
/hold cancel Project has been deleted. |
|
/retest |
|
|
|
I haven't heard back on a workaround for |
|
actually, I can probably do that... |
$ diff -u <(git show --pretty=fuller d352447ae) <(git show --pretty=fuller 299242f17)
--- /dev/fd/63 2019-04-05 14:02:00.196687845 -0700
+++ /dev/fd/62 2019-04-05 14:02:00.197687855 -0700
@@ -1,8 +1,8 @@
-commit d352447ae43f9fa0bd400e8505ed94af70a39aa8
+commit 299242f179b2449ff6b56a824de026c080c9d0e5
Author: staebler <staebler@redhat.com>
AuthorDate: Wed Apr 3 23:21:48 2019 -0400
-Commit: staebler <staebler@redhat.com>
-CommitDate: Fri Apr 5 09:11:02 2019 -0400
+Commit: W. Trevor King <wking@tremily.us>
+CommitDate: Fri Apr 5 14:00:56 2019 -0700
asset/password: KubeadminPassword responsible for the password file
/lgtm |
The KubeadminPassword asset owns the kube admin password, so that asset should own creating the password file.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The KubeadminPassword asset owns the kube admin password, so that asset should own creating the password file.