Skip to content

Conversation

@staebler
Copy link
Contributor

@staebler staebler commented Apr 5, 2019

The KubeadminPassword asset owns the kube admin password, so that asset should own creating the password file.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 5, 2019
@wking
Copy link
Member

wking commented Apr 5, 2019

no such image. Can you oc delete project ci-op-g3mjc86k?

@wking
Copy link
Member

wking commented Apr 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@wking
Copy link
Member

wking commented Apr 5, 2019

/hold

until you've deleted the busted project.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@staebler
Copy link
Contributor Author

staebler commented Apr 5, 2019

/hold cancel

Project has been deleted.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@staebler
Copy link
Contributor Author

staebler commented Apr 5, 2019

/retest

@wking
Copy link
Member

wking commented Apr 5, 2019

could not wait for build: could not find build src. Dunno about that one...

@wking
Copy link
Member

wking commented Apr 5, 2019

I haven't heard back on a workaround for could not wait for build: could not find.... Can you just push a bump to your commit timestamp to get a new commit hash, and I'll drop a fresh /lgtm?

@wking
Copy link
Member

wking commented Apr 5, 2019

actually, I can probably do that...

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@wking
Copy link
Member

wking commented Apr 5, 2019

$ diff -u <(git show --pretty=fuller d352447ae) <(git show --pretty=fuller 299242f17)
--- /dev/fd/63	2019-04-05 14:02:00.196687845 -0700
+++ /dev/fd/62	2019-04-05 14:02:00.197687855 -0700
@@ -1,8 +1,8 @@
-commit d352447ae43f9fa0bd400e8505ed94af70a39aa8
+commit 299242f179b2449ff6b56a824de026c080c9d0e5
 Author:     staebler <staebler@redhat.com>
 AuthorDate: Wed Apr 3 23:21:48 2019 -0400
-Commit:     staebler <staebler@redhat.com>
-CommitDate: Fri Apr 5 09:11:02 2019 -0400
+Commit:     W. Trevor King <wking@tremily.us>
+CommitDate: Fri Apr 5 14:00:56 2019 -0700
 
     asset/password: KubeadminPassword responsible for the password file
     

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
The KubeadminPassword asset owns the kube admin password, so that
asset should own creating the password file.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@wking
Copy link
Member

wking commented Apr 5, 2019

no packages to test. openshift/release#3369 unstuck some busted CI-cluster stuff. Bumped the commit hash again and repushed with 299242f17 -> 29cfc4d.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 99bcc21 into openshift:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants