Skip to content

pkg/asset: fix client cert key name #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Apr 3, 2019
Merged

pkg/asset: fix client cert key name #1526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/asset/tls/aggregator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func (a *AggregatorClientCertKey) Generate(dependencies asset.Parents) error {
Validity: ValidityOneDay,
}

return a.SignedCertKey.Generate(cfg, ca, "apiserver-proxy", DoNotAppendParent)
return a.SignedCertKey.Generate(cfg, ca, "aggregator-client", DoNotAppendParent)
Copy link
Member Author

@runcom runcom Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the same old name was already generated here https://github.com/openshift/installer/pull/1526/files#diff-8d9eb2f3ce41c8ad81321b7dc4d554d8R71 and that's why we had duplicate assets in #1468

}

// Name returns the human-friendly name of the asset.
Expand Down