pkg/asset: fix client cert key name #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on the Ignition v2s3 move, we noticed that we were generating a duplicate asset. That one had the same name "apiserver-proxy". The correct name _should_ be "aggregator-client". Signed-off-by: Antonio Murdaca <[email protected]>
openshift-ci-robot
added
the
size/XS
runcom
commented
Apr 3, 2019
| } | ||
|
|
||
| return a.SignedCertKey.Generate(cfg, ca, "apiserver-proxy", DoNotAppendParent) | ||
| return a.SignedCertKey.Generate(cfg, ca, "aggregator-client", DoNotAppendParent) |
Member
Author
There was a problem hiding this comment.
FYI, the same old name was already generated here https://github.com/openshift/installer/pull/1526/files#diff-8d9eb2f3ce41c8ad81321b7dc4d554d8R71 and that's why we had duplicate assets in #1468
Contributor
|
/lgtm cc @deads2k is the kao not using these tls assets? |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the Ignition v2s3 move, we noticed that we were
generating a duplicate asset. That one had the same name
"apiserver-proxy". The correct name should be "aggregator-client".
This may just have been a copy/paste error.
We're not sure how it worked before because what this is doing is overwriting an already written file (the other asset wrote that already and this piece of code is re-writing it with the same name)
Signed-off-by: Antonio Murdaca [email protected]