pkg/asset/manifests/infrastructure: Set InfrastructureName #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching up with openshift/api@c9b4e5b2d7 (Add InfrastructureName, 2019-03-01, openshift/api#266). Generated with: $ dep ensure -update github.com/openshift/api $ dep ensure -update github.com/openshift/client-go using: $ dep version dep: version : v0.5.1 build date : 2019-03-20 git hash : faa61893 go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false The client-go bump avoids: vendor/github.com/openshift/client-go/config/clientset/versioned/typed/config/v1/features.go:22:25: undefined: "github.com/openshift/installer/vendor/github.com/openshift/api/config/v1".Features by pulling in openshift/client-go@035cd9bc (bump API and regenerate for FeatureGate API, 2019-03-13, openshift/client-go#97) to match openshift/api@ee961910 (features: rename features to FeatureGate, 2019-03-05, openshift/api#247), which was also pulled in by the API bump.
So in-cluster components can pull the value and set their
kubernetes.io/cluster/{infraName} tags appropriately.
Also adjust to the AWSPlatform -> AWSPlatformType changes and similar
from openshift/api@c9b4e5b2d7 (Add InfrastructureName, 2019-03-01,
openshift/api#266).
Member
Author
|
CC @dgoodwin |
openshift-ci-robot
added
size/XL
Contributor
|
LGTM thanks! |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in-cluster components can pull the value and set their
kubernetes.io/cluster/{infraName}tags appropriately.Also adjust to the
AWSPlatform->AWSPlatformTypechanges and similar from openshift/api@c9b4e5b2d7 (openshift/api#266).