Skip to content

Conversation

@rphillips
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 13, 2019
@rphillips
Copy link
Contributor Author

/cc @sjenning @derekwaynecarr

@sjenning
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2019
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: derekwaynecarr, rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8ae2a9c into openshift:master Mar 13, 2019
wking added a commit to wking/openshift-installer that referenced this pull request Apr 1, 2019
Catching up with openshift/api@c9b4e5b2d7 (Add InfrastructureName,
2019-03-01, openshift/api#266).

Generated with:

  $ dep ensure -update github.com/openshift/api
  $ dep ensure -update github.com/openshift/client-go

using:

  $ dep version
  dep:
   version     : v0.5.1
   build date  : 2019-03-20
   git hash    : faa61893
   go version  : go1.10.3
   go compiler : gc
   platform    : linux/amd64
   features    : ImportDuringSolve=false

The client-go bump avoids:

  vendor/github.com/openshift/client-go/config/clientset/versioned/typed/config/v1/features.go:22:25: undefined: "github.com/openshift/installer/vendor/github.com/openshift/api/config/v1".Features

by pulling in openshift/client-go@035cd9bc (bump API and regenerate
for FeatureGate API, 2019-03-13, openshift/client-go#97) to match
openshift/api@ee961910 (features: rename features to FeatureGate,
2019-03-05, openshift/api#247), which was also pulled in by the API
bump.
eparis pushed a commit to eparis/client-go that referenced this pull request Apr 17, 2019
config: add status helper funcs for v1.ClusterOperator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants