Skip to content

Conversation

@sjenning
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjenning
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveej

If they are not already assigned, you can assign the PR to them by writing /assign @steveej in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Mar 26, 2019

I still don't see it in the bootstrap Ignition config

$ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_in
staller/1461/pull-ci-openshift-installer-master-e2e-aws/4625/artifacts/e2e-aws/installer/.openshift_install.log | grep -o '\(manifests\|openshift\)/[^.]*\.ya*ml'
openshift/manifests/04-openshift-machine-config-operator.yaml
openshift/manifests/cluster-config.yaml
openshift/manifests/cluster-dns-02-config.yml
openshift/manifests/cluster-infrastructure-02-config.yml
openshift/manifests/cluster-ingress-02-config.yml
openshift/manifests/cluster-network-01-crd.yml
openshift/manifests/cluster-network-02-config.yml
openshift/manifests/cvo-overrides.yaml
openshift/manifests/etcd-service.yaml
openshift/manifests/host-etcd-service-endpoints.yaml
openshift/manifests/host-etcd-service.yaml
openshift/manifests/kube-cloud-config.yaml
openshift/manifests/kube-system-configmap-etcd-ca-bundle.yaml
openshift/manifests/kube-system-configmap-etcd-serving-ca.yaml
openshift/manifests/kube-system-configmap-root-ca.yaml
openshift/manifests/kube-system-secret-etcd-client-ca-deprecated.yaml
openshift/manifests/kube-system-secret-etcd-client.yaml
openshift/manifests/kube-system-secret-etcd-signer-client.yaml
openshift/manifests/kube-system-secret-etcd-signer.yaml
openshift/manifests/machine-config-server-tls-secret.yaml
openshift/manifests/openshift-config-configmap-etcd-metrics-serving-ca.yaml
openshift/manifests/openshift-config-secret-etcd-metrics-client.yaml
openshift/openshift/99_binding-discovery.yaml
openshift/openshift/99_cloud-creds-secret.yaml
openshift/openshift/99_kubeadmin-password-secret.yaml
openshift/openshift/99_openshift-cluster-api_worker-machineset.yaml
openshift/openshift/99_openshift-cluster-api_worker-user-data-secret.yaml
openshift/openshift/99_role-cloud-creds-secret-reader.yaml
openshift/openshift/99_openshift-cluster-api_master-user-data-secret.yaml
openshift/openshift/99_openshift-cluster-api_master-machines-0.yaml
openshift/openshift/99_openshift-cluster-api_master-machines-1.yaml
openshift/openshift/99_openshift-cluster-api_master-machines-2.yaml

I can work up a fixup tomorrow.

@sjenning
Copy link
Contributor Author

@wking I think it worked. From the e2e installer log:

time="2019-03-26T03:48:44Z" level=debug msg="        Loading \"Install Config\"..."
time="2019-03-26T03:48:44Z" level=debug msg="        Loading \"Network CRDs\"..."
time="2019-03-26T03:48:44Z" level=debug msg="      Loading \"Scheduler Config\"..." <---
time="2019-03-26T03:48:44Z" level=debug msg="      Loading \"Root CA\"..."
time="2019-03-26T03:48:44Z" level=debug msg="      Loading \"Certificate (etcd)\"..."

@wking
Copy link
Member

wking commented Mar 26, 2019

You built the asset, but didn't include it in the Ignition config, so it's just sitting on your install host.

@wking
Copy link
Member

wking commented Mar 28, 2019

test-platform flake:

could not wait for template instance to be ready: could not determine if template instance was ready: failed to create objects: object is being deleted: pods "e2e-aws" already exists

/retest

@sjenning
Copy link
Contributor Author

sjenning commented Mar 28, 2019

/retest

@sjenning
Copy link
Contributor Author

e2e-aws is in shambles 😞

@wking
Copy link
Member

wking commented Mar 28, 2019

e2e-aws:

level=fatal msg="failed to wait for bootstrap-complete event: timed out waiting for the condition"

/retest

@wking
Copy link
Member

wking commented Mar 29, 2019

Hrm bootstrap-complete timeout again. Maybe its real, and not a flake?

@sjenning
Copy link
Contributor Author

/retest

@sjenning
Copy link
Contributor Author

superseded by openshift/cluster-config-operator#36

@sjenning sjenning closed this Apr 11, 2019
@sjenning
Copy link
Contributor Author

nevermind, we still need this

@sjenning sjenning reopened this Apr 11, 2019
@openshift-ci-robot
Copy link
Contributor

@sjenning: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 55a3709 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sjenning
Copy link
Contributor Author

nope, wrong again

@sjenning sjenning closed this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants