Skip to content

add empty CRs #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 11, 2019
Merged

add empty CRs #36

openshift-merge-robot merged 1 commit into from
Apr 11, 2019

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 11, 2019

from #15

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8bc283e into openshift:master Apr 11, 2019
@sjenning sjenning mentioned this pull request Apr 11, 2019
Closed
@sjenning
Copy link
Contributor

sjenning commented Apr 11, 2019

@deads2k do we need to remove the creation the installer does?
https://github.com/openshift/installer/tree/master/pkg/asset/manifests

@deads2k deads2k mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deads2k @openshift-ci-robot @sjenning @openshift-merge-robot