-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: update some language, worker -> compute, etc. #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We prefer to use the terms control plane and compute instead of master and worker.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| ## Elastic Load Balancing (ELB/NLB) | ||
|
|
||
| By default, each cluster will create 2 network load balancers for the master API server (1 internal, 1 external) and a | ||
| By default, each cluster will create 2 network load balancers for the API server (1 internal, 1 external) and a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"API server" -> "control plane", as the thing being balanced?
And looking back on the old wording, "master server" is an interesting juxtaposition :p.
| If no pods are shown, etcd will need to be [investigated](#etcd-is-not-running). | ||
|
|
||
| ### Unable to SSH into Master Nodes | ||
| ### Unable to SSH into Control Plane Nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since #1045, there's no significant difference between control-plane and compute machines. Maybe this should just be ### Unable to SSH into Nodes?
| ``` | ||
|
|
||
| And retrieve the logs. Note that, on multi-master systems, the operator will perform leader election and all other operators will sleep: | ||
| And retrieve the logs. Note that, on HA control planes, the operator will perform leader election and all other operators will sleep: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike most abbreviations in docs, so I'd prefer "HA" -> "high-availability". But I don't want folks spelling out "Uniform Resource Identifier", so there's certainly a gray area somewhere, and maybe HA is closer to "English" than "jargon" than it feels to me ;).
|
@crawford will we eventually be carrying over this language change to other repos (master/worker -> control plane/compute)? |
This is following upstream, kubernetes/website#6525, so I expect the whole ecosystem will gradually wander in this direction. |
|
@crawford: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@crawford: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This has long been abandoned. |
|
@crawford: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We prefer to use the terms control plane and compute instead of master
and worker.