Skip to content

Conversation

@crawford
Copy link
Contributor

We prefer to use the terms control plane and compute instead of master
and worker.

We prefer to use the terms control plane and compute instead of master
and worker.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
## Elastic Load Balancing (ELB/NLB)

By default, each cluster will create 2 network load balancers for the master API server (1 internal, 1 external) and a
By default, each cluster will create 2 network load balancers for the API server (1 internal, 1 external) and a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"API server" -> "control plane", as the thing being balanced?

And looking back on the old wording, "master server" is an interesting juxtaposition :p.

If no pods are shown, etcd will need to be [investigated](#etcd-is-not-running).

### Unable to SSH into Master Nodes
### Unable to SSH into Control Plane Nodes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #1045, there's no significant difference between control-plane and compute machines. Maybe this should just be ### Unable to SSH into Nodes?

```

And retrieve the logs. Note that, on multi-master systems, the operator will perform leader election and all other operators will sleep:
And retrieve the logs. Note that, on HA control planes, the operator will perform leader election and all other operators will sleep:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike most abbreviations in docs, so I'd prefer "HA" -> "high-availability". But I don't want folks spelling out "Uniform Resource Identifier", so there's certainly a gray area somewhere, and maybe HA is closer to "English" than "jargon" than it feels to me ;).

@kikisdeliveryservice
Copy link
Contributor

@crawford will we eventually be carrying over this language change to other repos (master/worker -> control plane/compute)?

@wking
Copy link
Member

wking commented Mar 2, 2019

will we eventually be carrying over this language change to other repos (master/worker -> control plane/compute)?

This is following upstream, kubernetes/website#6525, so I expect the whole ecosystem will gradually wander in this direction.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2019
@openshift-ci-robot
Copy link
Contributor

@crawford: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking changed the title docs: update some language docs: update some language, worker -> compute, etc. Apr 25, 2019
@openshift-ci-robot
Copy link
Contributor

@crawford: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 866589f link /test e2e-aws-upgrade
ci/prow/e2e-aws 866589f link /test e2e-aws
ci/prow/e2e-aws-disruptive 866589f link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crawford
Copy link
Contributor Author

crawford commented Oct 8, 2019

This has long been abandoned.

@openshift-ci-robot
Copy link
Contributor

@crawford: Closed this PR.

Details

In response to this:

This has long been abandoned.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants