-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update GCP user docs #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GCP user docs #2355
Conversation
Azure limits doc has embedded html which is causing the heading to be rendered as a basic hyperlink. Instead, this uses github-flavored markdown to generate the links to the headings.
efc8a36 to
ecaf38d
Compare
|
CC @kalexand-rh |
Update all GCP user docs to bring up to standard of equivalent AWS docs.
ecaf38d to
19cd1a4
Compare
|
@patrickdillon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CORS-1192
This PR attempts to bring GCP up to the standard of the AWS docs.
Notes on specific sections:
DNS
I don't think I can get the Step 4a Update Registrar Example screenshot without registering a domain (or doctoring the screen shot).
Similarly I left out the BIND example and the example that would correspond to Example: Route53
Limits
I took a different approach in this section compared to AWS.
Installation
@Cuppet created an awesome aws architecture diagram https://github.com/openshift/installer/blob/master/docs/user/aws/install.md#running-cluster I would need to invest some time to create an equivalent.