Skip to content

Prow: Add Terraform lint #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 3 commits into from
Aug 6, 2018
Merged

Prow: Add Terraform lint #109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2592d1e
Prow: Add Terraform lint
Aug 3, 2018
1b48ff1
Merge branch 'master' of github.com:openshift/installer into CORS-744
Aug 6, 2018
9adbef9
Prow: Add Terraform lint. Code review: remove additional - from travi…
Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ branches:
jobs:
include:
- stage: Lint & Test
- script: ./hack/tf-lint.sh
Copy link
Member

@wking wking Aug 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first entry after - stage doesn't need a hyphen (so - script -> script here). The hyphen you're adding is causing Travis to run this dummy job.

name: Terraform lint
script: docker run -v $(pwd):/data -t quay.io/coreos/tflint
- script: ./hack/yaml-lint.sh
name: YAML lint
- script: ./hack/shellcheck.sh
Expand Down
6 changes: 6 additions & 0 deletions hack/tf-lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/bin/sh
if [ "$IS_CONTAINER" != "" ]; then
tflint
else
docker run -t --rm -v "$(pwd)":/data --env IS_CONTAINER='TRUE' --entrypoint sh quay.io/coreos/tflint ./hack/tf-lint.sh
fi;