Skip to content

Conversation

@alejovicu
Copy link
Contributor

  • Add Terraform lintern script for Prow Task.
  • Update Travis to use the tf-lint script.

Prow configuration:
openshift/release#1124

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2018
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

.travis.yml Outdated
jobs:
include:
- stage: Lint & Test
- script: ./hack/tf-lint.sh
Copy link
Member

@wking wking Aug 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first entry after - stage doesn't need a hyphen (so - script -> script here). The hyphen you're adding is causing Travis to run this dummy job.

@yifan-gu
Copy link
Contributor

yifan-gu commented Aug 6, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2018
@alejovicu
Copy link
Contributor Author

/retest

Copy link
Contributor

@yifan-gu yifan-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejovicu, yifan-gu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2018
@openshift-merge-robot openshift-merge-robot merged commit f770a6a into openshift:master Aug 6, 2018
@alejovicu alejovicu deleted the CORS-744 branch August 8, 2018 20:24
miyamotoh pushed a commit to miyamotoh/installer that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants