-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Prow: Add Terraform lint #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise LGTM.
.travis.yml
Outdated
| jobs: | ||
| include: | ||
| - stage: Lint & Test | ||
| - script: ./hack/tf-lint.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first entry after - stage doesn't need a hyphen (so - script -> script here). The hyphen you're adding is causing Travis to run this dummy job.
|
/ok-to-test |
|
/retest |
yifan-gu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alejovicu, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
don't set default arch
Prow configuration:
openshift/release#1124