Skip to content

Bug 1918376: ICSP support during Image Registry pullthrough #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Jun 11, 2021
Merged

Bug 1918376: ICSP support during Image Registry pullthrough #277

openshift-merge-robot merged 3 commits into from
Jun 11, 2021

Conversation

@ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Jun 7, 2021

This PR adds ICSP support to Image Registry during pullthrough operations.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2021

@ricardomaraschini: This pull request references Bugzilla bug 1918376, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

WIP - Bug 1918376: ICSP support during Image Registry pullthrough

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dmage, gabemontero and xiuwang June 7, 2021 08:45
@ricardomaraschini ricardomaraschini mentioned this pull request Jun 7, 2021
Closed
@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Jun 8, 2021

/assign @dmage

@ricardomaraschini ricardomaraschini changed the title WIP - Bug 1918376: ICSP support during Image Registry pullthrough Bug 1918376: ICSP support during Image Registry pullthrough Jun 10, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2021
dmage
dmage reviewed Jun 10, 2021
View reviewed changes
pkg/dockerregistry/server/pullthroughmanifestservice.go Outdated
}

func (m *pullthroughManifestService) getRemoteRepositoryClient(ctx context.Context, ref *imageapi.DockerImageReference, dgst digest.Digest, options ...distribution.ManifestServiceOption) (distribution.Repository, error) {
dcontext.GetLogger(ctx).Info("(*pullthroughManifestService).getRemoteRepositoryClient")
Copy link
Contributor

@dmage dmage Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's Debug

Copy link
Contributor Author

@ricardomaraschini ricardomaraschini Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@ricardomaraschini
ICSP support
bc05142 
Implements ICSP support for image registry.
@ricardomaraschini
Using vendored packages during integration tests
1f79997 
Adding "-mod vendor" flag to go test command.
@openshift-ci openshift-ci bot mentioned this pull request Jun 10, 2021
Merged
@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Jun 10, 2021

/retest

@dmage
Copy link
Contributor

dmage commented Jun 10, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@dmage
Copy link
Contributor

dmage commented Jun 11, 2021

Step e2e-aws-upgrade-openshift-e2e-test succeeded

/override ci/prow/e2e-aws-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

@dmage: Overrode contexts on behalf of dmage: ci/prow/e2e-aws-upgrade

Details

In response to this:

Step e2e-aws-upgrade-openshift-e2e-test succeeded

/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a87e6c5 into openshift:master Jun 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

@ricardomaraschini: All pull requests linked via external trackers have merged:

Bugzilla bug 1918376 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1918376: ICSP support during Image Registry pullthrough

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiuwang xiuwang Awaiting requested review from xiuwang

@gabemontero gabemontero Awaiting requested review from gabemontero

1 more reviewer

@dmage dmage dmage left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dmage dmage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ricardomaraschini @dmage @openshift-bot @openshift-merge-robot