WIP - Bug 1918376: ICSP support during Image Registry pullthrough #267
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/retest |
2 similar comments
|
/retest |
|
/retest |
ricardomaraschini
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@ricardomaraschini: This pull request references Bugzilla bug 1918376, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ricardomaraschini
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
@ricardomaraschini: This pull request references Bugzilla bug 1918376, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @dmage |
|
@dmage Even though we still don't have a definitive version for openshift/library-go#939 it might be good to start reviewing this. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardomaraschini The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| ).WithRequestModifiers( | ||
| requesttrace.New(ctx, req), | ||
| ).WithAlternateRepositoryStrategy( | ||
| strategy.NewSimpleLookupICSPStrategy("", icsp), |
There was a problem hiding this comment.
This strategy shouldn't be used by the registry. The registry shouldn't ask api-server for a list for ICSPs on every incoming request, it should use informers that use watches to update their cache.
|
Need to launch a disconnect cluster which is blocked by qe jenkins job outage. |
|
@xiuwang please don't test WIP (work-in-progress) PRs |
LatencyMetric and ResultMetric interfaces now include a context.Context as the first parameter.
This commit makes registry to start taking ICSP rules into account when doing pullthrough operations.
Last changes in library-go made it uneeded.
API has changed and now this should return imageapiv1.SecretList and not core.SecretList.
Tests now depend on being capable of reading ICSP rules. This commit injects the needed client whenever it is needed.
Implementing tests to validate ICSP assessment during pullthrough operations.
|
@ricardomaraschini: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this one as there is a new PR to add ICSP support: #277 |
|
@ricardomaraschini: This pull request references Bugzilla bug 1918376. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This PR adds ICSP support to Image Registry during pullthrough operations.
Depends on openshift/cluster-image-registry-operator#668