-
Notifications
You must be signed in to change notification settings - Fork 567
NO-JIRA: chore(karpenter): bump karpenter-provider-aws vendor and sync CRDs #9109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jhjaggars
wants to merge
2
commits into
openshift:main
from
jhjaggars:sync-karpenter-ec2nodeclass-crd
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/hypershift
Length of output: 50376
🌐 Web query:
controller-runtime compatibility table v0.23 v0.22 kubernetes v0.35 v0.34💡 Result:
Controller-runtime versions are aligned with Kubernetes library (client-go, apimachinery, etc.) versions [1][2]. Each minor version of controller-runtime is tested against a specific minor version of these Kubernetes dependencies [1][2]. The compatibility for the requested versions is as follows [1][2][3]: - Controller-runtime v0.23 is compatible with Kubernetes library dependencies v0.35 [1][2][3]. - Controller-runtime v0.22 is compatible with Kubernetes library dependencies v0.34 [1][2][3]. While controller-runtime may happen to work with other versions of Kubernetes dependencies, such combinations are not supported or tested by the project [1][2]. Users are advised to check the go.mod file of their specific controller-runtime version for the exact dependencies used [1][2].
Citations:
Align the controller-runtime replacement with the Kubernetes minor version
replacemakes the effective controller-runtime versionv0.22.5, but the module graph is onk8s.io/* v0.35.3. That pairing is outside controller-runtime’s supported matrix (v0.22↔v0.34,v0.23↔v0.35). Either remove the downgrade and keepv0.23.1, or align the Kubernetes modules to the supportedv0.22set.🤖 Prompt for AI Agents