NO-JIRA: chore(karpenter): bump karpenter-provider-aws vendor and sync CRDs - #9109
NO-JIRA: chore(karpenter): bump karpenter-provider-aws vendor and sync CRDs#9109jhjaggars wants to merge 2 commits into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jhjaggars: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
do-not-merge/work-in-progress
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (4)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughUpdates Kubernetes modules from Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci
Bot
added
area/karpenter-operator
|
/pipeline required |
|
Scheduling tests matching the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9109 +/- ##
==========================================
+ Coverage 44.51% 44.56% +0.04%
==========================================
Files 774 774
Lines 96997 97003 +6
==========================================
+ Hits 43179 43228 +49
+ Misses 50830 50783 -47
- Partials 2988 2992 +4 see 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…Shift forks Bump the karpenter-provider-aws replace to openshift/aws-karpenter-provider-aws at commit abcf7d1e3417 (release-5.0 head) and update the karpenter core replace to the matching openshift/kubernetes-sigs-karpenter fork at 2b8ed744bf1c. Pin controller-runtime to v0.22.5 to avoid a breaking API change in v0.23.x (NewWebhookManagedBy signature) that would require bumping all vendored CAPI providers simultaneously. Transitive dependency updates pulled in by the bump: - github.com/awslabs/operatorpkg 2025-12-22 → 2026-05-01 - github.com/samber/lo v1.52.0 → v1.53.0 - github.com/aws/aws-sdk-go-v2/service/eks v1.77.0 → v1.84.5 - k8s.io/api, k8s.io/apimachinery, k8s.io/client-go v0.35.1 → v0.35.3 Signed-off-by: Jesse Jaggars <jjaggars@redhat.com> Commit-Message-Assisted-by: Claude (via Claude Code)
22de8ad to
8026753
Compare
jhjaggars
changed the title
|
@jhjaggars: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
Bot
added
the
area/api
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhjaggars The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 128-129: Update the controller-runtime dependency configuration so
its effective version matches the Kubernetes module minor version: retain
v0.23.1 without a replacement, or consistently downgrade the k8s.io modules to
the supported v0.34 set for v0.22.5. Ensure the module graph no longer combines
controller-runtime v0.22.5 with Kubernetes v0.35.3.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 484bd44f-5976-4d25-95ee-aa05ed4c80ff
⛔ Files ignored due to path filters (128)
api/go.sumis excluded by!**/*.sumapi/vendor/modules.txtis excluded by!**/vendor/**go.sumis excluded by!**/*.sumkarpenter-operator/controllers/karpenter/assets/karpenter.k8s.aws_ec2nodeclasses.yamlis excluded by!karpenter-operator/controllers/karpenter/assets/*.yamlkarpenter-operator/controllers/karpenter/assets/karpenter.sh_nodeclaims.yamlis excluded by!karpenter-operator/controllers/karpenter/assets/*.yamlkarpenter-operator/controllers/karpenter/assets/karpenter.sh_nodeoverlays.yamlis excluded by!karpenter-operator/controllers/karpenter/assets/*.yamlkarpenter-operator/controllers/karpenter/assets/karpenter.sh_nodepools.yamlis excluded by!karpenter-operator/controllers/karpenter/assets/*.yamlvendor/github.com/aws/aws-sdk-go-v2/internal/middleware/middleware.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_AssociateAccessPolicy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_AssociateEncryptionConfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_AssociateIdentityProviderConfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_CreateAccessEntry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_CreateAddon.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_CreateCapability.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_CreateCluster.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_CreateEksAnywhereSubscription.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_CreateFargateProfile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_CreateNodegroup.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_CreatePodIdentityAssociation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeleteAccessEntry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeleteAddon.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeleteCapability.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeleteCluster.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeleteEksAnywhereSubscription.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeleteFargateProfile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeleteNodegroup.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeletePodIdentityAssociation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DeregisterCluster.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeAccessEntry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeAddon.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeAddonConfiguration.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeAddonVersions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeCapability.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeCluster.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeClusterVersions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeEksAnywhereSubscription.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeFargateProfile.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeIdentityProviderConfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeInsight.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeInsightsRefresh.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeNodegroup.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribePodIdentityAssociation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DescribeUpdate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DisassociateAccessPolicy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_DisassociateIdentityProviderConfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListAccessEntries.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListAccessPolicies.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListAddons.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListAssociatedAccessPolicies.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListCapabilities.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListClusters.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListEksAnywhereSubscriptions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListFargateProfiles.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListIdentityProviderConfigs.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListInsights.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListNodegroups.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListPodIdentityAssociations.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListTagsForResource.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_ListUpdates.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_RegisterCluster.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_StartInsightsRefresh.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_TagResource.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UntagResource.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdateAccessEntry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdateAddon.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdateCapability.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdateClusterConfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdateClusterVersion.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdateEksAnywhereSubscription.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdateNodegroupConfig.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdateNodegroupVersion.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/api_op_UpdatePodIdentityAssociation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/auth.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/deserializers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/endpoints.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/generated.jsonis excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/go_module_metadata.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/serializers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/types/enums.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/aws-sdk-go-v2/service/eks/types/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/karpenter-provider-aws/pkg/apis/crds/karpenter.k8s.aws_ec2nodeclasses.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/karpenter-provider-aws/pkg/apis/crds/karpenter.sh_nodeclaims.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/karpenter-provider-aws/pkg/apis/crds/karpenter.sh_nodeoverlays.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/karpenter-provider-aws/pkg/apis/crds/karpenter.sh_nodepools.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/karpenter-provider-aws/pkg/apis/v1/ec2nodeclass.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/karpenter-provider-aws/pkg/apis/v1/ec2nodeclass_status.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/karpenter-provider-aws/pkg/apis/v1/labels.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/aws/karpenter-provider-aws/pkg/apis/v1/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated*.go,!**/zz_generated*vendor/github.com/awslabs/operatorpkg/status/condition.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/awslabs/operatorpkg/status/condition_set.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/awslabs/operatorpkg/status/unstructured_adapter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/openshift/hypershift/api/hypershift/v1beta1/zz_generated.featuregated-crd-manifests.yamlis excluded by!vendor/**,!**/vendor/**,!**/zz_generated*vendor/github.com/samber/lo/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/Makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/channel.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/concurrency.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/condition.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/find.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/intersect.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/map.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/math.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/mutable/slice.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/retry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/slice.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/string.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/time.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/tuples.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/samber/lo/type_manipulation.gois excluded by!vendor/**,!**/vendor/**vendor/k8s.io/client-go/kubernetes/fake/clientset_generated.gois excluded by!vendor/**,!**/vendor/**vendor/modules.txtis excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/apis/crds/karpenter.sh_nodeclaims.yamlis excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/apis/crds/karpenter.sh_nodeoverlays.yamlis excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/apis/crds/karpenter.sh_nodepools.yamlis excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/apis/v1/duration.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/apis/v1/nodeclaim.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/apis/v1/nodeclaim_status.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/apis/v1/nodepool.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/apis/v1/nodepool_status.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/cloudprovider/types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/operator/logging/logging.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/scheduling/taints.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/scheduling/volumeusage.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/karpenter/pkg/utils/pretty/pretty.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (2)
api/go.modgo.mod
| sigs.k8s.io/controller-runtime v0.23.1 | ||
| sigs.k8s.io/karpenter v1.13.0 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
go list -m -json sigs.k8s.io/controller-runtime k8s.io/api k8s.io/apimachinery k8s.io/client-go
go mod graph | rg 'sigs.k8s.io/controller-runtime|k8s.io/(api|apimachinery|client-go)'Repository: openshift/hypershift
Length of output: 50376
🌐 Web query:
controller-runtime compatibility table v0.23 v0.22 kubernetes v0.35 v0.34
💡 Result:
Controller-runtime versions are aligned with Kubernetes library (client-go, apimachinery, etc.) versions [1][2]. Each minor version of controller-runtime is tested against a specific minor version of these Kubernetes dependencies [1][2]. The compatibility for the requested versions is as follows [1][2][3]: - Controller-runtime v0.23 is compatible with Kubernetes library dependencies v0.35 [1][2][3]. - Controller-runtime v0.22 is compatible with Kubernetes library dependencies v0.34 [1][2][3]. While controller-runtime may happen to work with other versions of Kubernetes dependencies, such combinations are not supported or tested by the project [1][2]. Users are advised to check the go.mod file of their specific controller-runtime version for the exact dependencies used [1][2].
Citations:
- 1: https://github.com/kubernetes-sigs/controller-runtime?tab=readme-ov-file
- 2: https://github.com/kubernetes-sigs/controller-runtime/blob/main/README.md
- 3: https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.23.3
Align the controller-runtime replacement with the Kubernetes minor version
replace makes the effective controller-runtime version v0.22.5, but the module graph is on k8s.io/* v0.35.3. That pairing is outside controller-runtime’s supported matrix (v0.22 ↔ v0.34, v0.23 ↔ v0.35). Either remove the downgrade and keep v0.23.1, or align the Kubernetes modules to the supported v0.22 set.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 128 - 129, Update the controller-runtime dependency
configuration so its effective version matches the Kubernetes module minor
version: retain v0.23.1 without a replacement, or consistently downgrade the
k8s.io modules to the supported v0.34 set for v0.22.5. Ensure the module graph
no longer combines controller-runtime v0.22.5 with Kubernetes v0.35.3.
Run `make karpenter-api` to copy the updated CRDs from the vendored karpenter-provider-aws and apply OpenShift-specific CEL relaxations via adjust-cel.sh. New EC2NodeClass fields now available in the CRD: - connectionTracking: idle connection tracking timeouts on ENIs - cpuOptions: nested virtualization filtering for instance types - networkInterfaces: network interface configurations for instances - placementGroupSelector: placement group selection by name or id Also syncs updated CRDs for NodeClaim, NodePool, and NodeOverlay. Signed-off-by: Jesse Jaggars <jjaggars@redhat.com> Commit-Message-Assisted-by: Claude (via Claude Code)
8026753 to
cdf8713
Compare
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
What this PR does / why we need it:
Bumps the
karpenter-provider-awsvendor to openshift/aws-karpenter-provider-aws at commitabcf7d1e3417(release-5.0 head) and runsmake karpenter-apito sync the CRDs withOpenShift-specific CEL relaxations applied.
The karpenter-provider-aws binary in the 5.0 payload includes several new features that
require both Go type and CRD schema updates:
interruptiblestatus fieldDependency changes
karpenter-provider-aws(replace)f0be9c72e5bf(2026-03-11)abcf7d1e3417(2026-07-22)karpenter(replace)67e201b559d5(2026-03-10)2b8ed744bf1c(2026-07-21)operatorpkgsamber/loaws-sdk-go-v2/service/eksk8s.io/*controller-runtimeController-runtime is pinned at v0.22.5 because v0.23.x changes the
NewWebhookManagedBysignature, which would require bumping all vendored CAPI providers simultaneously.
Which issue(s) this PR fixes:
Special notes for your reviewer:
The CRD file (
karpenter.k8s.aws_ec2nodeclasses.yaml) is produced bymake karpenter-api,which copies the CRD from the vendor and applies OpenShift-specific CEL relaxations via
adjust-cel.sh. This is the standard karpenter CRD sync workflow.Checklist:
Summary by CodeRabbit