API-1835: Scaffold dynamic informers by p0lyn0mial · Pull Request #7477 · openshift/hypershift

p0lyn0mial · 2026-01-14T13:06:58Z

Adds an input resource initializer runnable for OpenShiftManager that discovers
input resources and wires informers, and registers it in the controller setup.

Notes: discovery is still a stub and we still need to register informer handlers and add filtering.

requires: #7445

openshift-ci-robot · 2026-01-14T13:07:03Z

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Adds an input resource initializer runnable for OpenShiftManager that discovers
input resources and wires informers, and registers it in the controller setup.

Notes: discovery is still a stub and we still need to register informer handlers and add filtering.

requires: #7445

please review only the last commit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-01-14T13:07:18Z

Walkthrough

Adds a non-exported inputResourceInitializer that discovers and validates operator input resources, resolves GVKs via the management RESTMapper, starts deduplicated informers on the management cache and waits for cache sync; wires the initializer into controller setup, adds unit tests, and updates go.mod.

Changes

Cohort / File(s)	Summary
Input Resource Initializer Implementation `control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go`	New file introducing `inputResourceInitializer` and `newInputResourceInitializer`; implements `Start(ctx) error`, stubbed `discoverInputResources()`, `checkSupportedInputResources`, GVK resolution via RESTMapper, deduplicated informer start via cache.GetInformerForKind + BlockUntilSynced, cache sync wait, and TODOs for event handlers.
Controller Integration `control-plane-operator/controllers/openshiftmanager/openshiftmanager_controller.go`	Replaces a not-implemented return with creation and registration of the inputResourceInitializer using `mgr.GetRESTMapper()` and `mgr.GetCache()`; removes an unused `fmt` import.
Unit Tests & Test Helpers `control-plane-operator/controllers/openshiftmanager/input_resource_initializer_test.go`	New tests exercising `checkSupportedInputResources` and `startAndWaitForInformersFor`; includes `fakeCache`, `fakeRESTMapperFor`, scenarios for GVK deduplication, mapper errors, informer errors, and cache sync outcomes.
Module Dependencies `go.mod`	Adds `github.com/openshift/multi-operator-manager v0.0.0-20260112172834-b64ebc8c627b` and new indirect dependencies (`github.com/PaesslerAG/gval`, `github.com/PaesslerAG/jsonpath`, `github.com/shopspring/decimal`).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

p0lyn0mial · 2026-01-14T13:07:33Z

/assign @benluddy @bertinatto @csrwng

p0lyn0mial · 2026-01-14T13:08:35Z

+}
+
+func (r *inputResourceInitializer) discoverInputResources() (map[string]*libraryinputresources.InputResources, error) {
+	return nil, fmt.Errorf("not implemented")


@benluddy this is where we could use the file sytem queue client to discover the input-res per operator.

p0lyn0mial · 2026-01-14T13:09:02Z

+			}
+
+			if registeredGVK.Has(gvk.String()) {
+				continue


so that we don't register multiple event handlers for the same gvk

We could register multiple even handlers once we have more than one operator, right? Would make sense to move the declaration of registeredGVK out of the loop?

I think that gvk can only be registered once. For operators requiring the same gvk we will register multiple filters.

p0lyn0mial · 2026-01-14T13:09:32Z

+		//
+		// TODO: in the future we need to extend to full list
+		registeredGVK := sets.NewString()
+		for _, exactResource := range resources.ApplyConfigurationResources.ExactResources {


for the poc we only support ApplyConfigurationResources.ExactResources in the future we need to cover the entire list

p0lyn0mial · 2026-01-14T13:10:24Z

+			return ctx.Err()
+		}
+		return fmt.Errorf("caches did not sync")
+	}


i forgot to add a TODO but at the end we need to send a signal to the main controller the caches are ready.

p0lyn0mial · 2026-01-14T13:11:59Z

+			if err != nil {
+				return err
+			}
+			// TODO: register informer event handlers


events will be passed to a different component that will be responsible for mapping resources to an operator and trigger the main controller. something like "if X resource(s) change then call/rigger this operator"

p0lyn0mial · 2026-01-14T15:49:39Z

+	"context"
+	"fmt"
+
+	"github.com/openshift/multi-operator-manager/pkg/library/libraryinputresources"


we will also pull a new dep

Do modules that depend on multi-operator-manager need to keep their Kube dependencies in sync with multi-operator-manager's Kube dependencies? I don't know if we will (in the future) want/need to either (a) avoid a specific dependency in multi-operator-manager or (b) split multi-operator-manager into separate modules for e.g. parent, child, API.

yeah, I think the modules need to keep their Kube deps in sync with the multi-operator-manager’s Kube deps.

this is a similar situation to what we already have today with library-go, which is used by HyperShift and also depends on a specific Kube version.

moreover, multi-operator-manager also uses library-go.

because of these intertwined dependencies, I think that we will be forced to keep all of the deps at the same level.

openshift-ci-robot · 2026-01-16T11:31:37Z

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Adds an input resource initializer runnable for OpenShiftManager that discovers
input resources and wires informers, and registers it in the controller setup.

Notes: discovery is still a stub and we still need to register informer handlers and add filtering.

requires: #7445

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

csrwng · 2026-01-19T13:42:44Z

/approve

Looks like you need to fix your commit messages.

openshift-ci · 2026-01-19T13:42:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

p0lyn0mial · 2026-01-19T14:33:50Z

/verified by CI

p0lyn0mial · 2026-01-20T11:17:11Z

/verified by CI

openshift-ci-robot · 2026-01-20T11:17:23Z

@p0lyn0mial: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

p0lyn0mial · 2026-01-20T11:27:39Z

/verified by CI

openshift-ci-robot · 2026-01-20T11:27:51Z

@p0lyn0mial: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go`:
- Around line 36-49: The discoverInputResources function currently returns a
"not implemented" error which causes inputResourceInitializer.Start to always
fail; change discoverInputResources to return an empty
map[string]*libraryinputresources.InputResources and a nil error (i.e., make it
a no-op stub) so Start can proceed to checkSupportedInputResources and
startAndWaitForInformersFor without failing; update the function body of
discoverInputResources (referenced by inputResourceInitializer.Start) to return
make(map[string]*libraryinputresources.InputResources), nil.

♻️ Duplicate comments (1)

control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go (1)

51-86: Deduplicate GVK registrations across operators.

registeredGVK is reset per-operator, so shared GVKs across operators will repeat GetInformerForKind calls and could lead to duplicate event handlers later. Consider de-duplicating across all operators.

♻️ Suggested refactor

 func (r *inputResourceInitializer) startAndWaitForInformersFor(ctx context.Context, inputResources map[string]*libraryinputresources.InputResources) error {
-	for operator, resources := range inputResources {
+	registeredGVK := sets.NewString()
+	for operator, resources := range inputResources {
 		// note that for the POC we are only interested in ApplyConfigurationResources.ExactResources
 		// the checkSupportedInputResources ensures no other resources were provided.
 		//
 		// TODO: in the future we need to extend to full list
-		registeredGVK := sets.NewString()
 		for _, exactResource := range resources.ApplyConfigurationResources.ExactResources {
 			gvr := schema.GroupVersionResource{Group: exactResource.Group, Version: exactResource.Version, Resource: exactResource.Resource}
 			gvk, err := r.managementClusterRESTMapper.KindFor(gvr)

coderabbitai · 2026-01-20T11:43:00Z

+func (r *inputResourceInitializer) Start(ctx context.Context) error {
+	inputResources, err := r.discoverInputResources()
+	if err != nil {
+		return err
+	}
+	if err = r.checkSupportedInputResources(inputResources); err != nil {
+		return err
+	}
+	return r.startAndWaitForInformersFor(ctx, inputResources)
+}
+
+func (r *inputResourceInitializer) discoverInputResources() (map[string]*libraryinputresources.InputResources, error) {
+	return nil, fmt.Errorf("not implemented")
+}


⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go

Repository: openshift/hypershift

Length of output: 6116

🏁 Script executed:

cd control-plane-operator/controllers/openshiftmanager && rg -A 5 -B 5 "newInputResourceInitializer|inputResourceInitializer" --type go

Repository: openshift/hypershift

Length of output: 6171

🏁 Script executed:

cd control-plane-operator && rg -B 5 -A 5 "SetupWithManager" controllers/openshiftmanager/openshiftmanager_controller.go

Repository: openshift/hypershift

Length of output: 426

🏁 Script executed:

cd control-plane-operator/controllers/openshiftmanager && git log --oneline -n 20 input_resource_initializer.go

Repository: openshift/hypershift

Length of output: 114

🏁 Script executed:

cd control-plane-operator/controllers/openshiftmanager && git log --oneline -n 50 | head -20

Repository: openshift/hypershift

Length of output: 114

🏁 Script executed:

cd control-plane-operator/controllers/openshiftmanager && git show 2a4b59b46 --stat

Repository: openshift/hypershift

Length of output: 50378

🏁 Script executed:

cd control-plane-operator/controllers/openshiftmanager && grep -r "SetupWithManager\|Add.*inputResInitializer" --include="*.go" -B 10 -A 2

Repository: openshift/hypershift

Length of output: 1002

🏁 Script executed:

cd control-plane-operator && rg "SetupWithManager.*OpenShiftManager\|openshiftmanager_controller.Reconciler" --include="*.go" -B 5 -A 5

Repository: openshift/hypershift

Length of output: 505

🏁 Script executed:

cd control-plane-operator && rg "SetupWithManager" -t go -B 5 -A 5 | head -50

Repository: openshift/hypershift

Length of output: 2730

🏁 Script executed:

cd control-plane-operator && rg "openshiftmanager.*Reconciler\|OpenShiftManager" -t go -B 3 -A 3

Repository: openshift/hypershift

Length of output: 46

🏁 Script executed:

cd control-plane-operator && rg "openshiftmanager" -t go -i

Repository: openshift/hypershift

Length of output: 558

🏁 Script executed:

cd control-plane-operator && rg "openshiftmanager.Reconciler\|controllers/openshiftmanager" -t go -B 5 -A 5

Repository: openshift/hypershift

Length of output: 46

🏁 Script executed:

cd control-plane-operator && find . -name "main.go" -type f | xargs grep -l "openshiftmanager\|OpenShiftManager" 2>/dev/null

Repository: openshift/hypershift

Length of output: 48

🏁 Script executed:

cd control-plane-operator && find . -name "*.go" -type f | xargs grep -l "SetupWithManager" | head -5

Repository: openshift/hypershift

Length of output: 352

🏁 Script executed:

cd control-plane-operator && find . -name "main.go" | xargs cat | grep -B 10 -A 10 "openshiftmanager"

Repository: openshift/hypershift

Length of output: 46

🏁 Script executed:

cd control-plane-operator && find . -name "main.go" -o -name "setup.go" | head -5

Repository: openshift/hypershift

Length of output: 364

Return empty map instead of error to prevent startup failure.

The Start method will always fail with the "not implemented" error from discoverInputResources, causing manager startup to fail whenever this initializer is enabled. The suggested fix to return an empty map is the appropriate mitigation until discovery is implemented.

🛠️ Suggested no-op stub to avoid startup failure

func (r *inputResourceInitializer) discoverInputResources() (map[string]*libraryinputresources.InputResources, error) { - return nil, fmt.Errorf("not implemented") + // TODO: implement discovery; for now return no input resources. + return map[string]*libraryinputresources.InputResources{}, nil }

🤖 Prompt for AI Agents

In `@control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go` around lines 36 - 49, The discoverInputResources function currently returns a "not implemented" error which causes inputResourceInitializer.Start to always fail; change discoverInputResources to return an empty map[string]*libraryinputresources.InputResources and a nil error (i.e., make it a no-op stub) so Start can proceed to checkSupportedInputResources and startAndWaitForInformersFor without failing; update the function body of discoverInputResources (referenced by inputResourceInitializer.Start) to return make(map[string]*libraryinputresources.InputResources), nil.

bertinatto · 2026-01-20T18:01:22Z

+
+			_, err = r.managementClusterCache.GetInformerForKind(ctx, gvk, cache.BlockUntilSynced(true))
+			if err != nil {
+				return err


nit: maybe add some context for this error?

I can do that in a follow-up.

Had to rebase (Konflux) the PR and decided to add more context.

bertinatto · 2026-01-20T18:09:46Z

+			}
+
+			if registeredGVK.Has(gvk.String()) {
+				continue


We could register multiple even handlers once we have more than one operator, right? Would make sense to move the declaration of registeredGVK out of the loop?

bertinatto

/lgtm

I think we can follow-up with a different PR if we need other changes.

openshift-ci-robot · 2026-01-20T19:01:26Z

/retest-required

Remaining retests: 0 against base HEAD ee28abe and 2 for PR HEAD 2a4b59b in total

Adds an input resource initializer runnable for OpenShiftManager that discovers input resources and wires informers, and registers it in the controller setup. Notes: discovery is still a stub and we still need to register informer handlers and add filtering.

updated dependencies reqired by the changes introduced in 7477 PR.

p0lyn0mial · 2026-01-21T09:16:44Z

/verified by CI

openshift-ci-robot · 2026-01-21T09:17:01Z

@p0lyn0mial: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

p0lyn0mial · 2026-01-21T10:24:35Z

/retest-required

p0lyn0mial · 2026-01-21T10:32:06Z

/verified by CI

openshift-ci-robot · 2026-01-21T10:32:18Z

@p0lyn0mial: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bertinatto · 2026-01-21T10:48:29Z

/lgtm

openshift-ci · 2026-01-21T16:20:51Z

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2026

openshift-ci Bot added the do-not-merge/needs-area label Jan 14, 2026

openshift-ci Bot assigned benluddy, bertinatto and csrwng Jan 14, 2026

openshift-ci Bot requested review from jparrill and sjenning January 14, 2026 13:07

openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jan 14, 2026

p0lyn0mial commented Jan 14, 2026

View reviewed changes

Comment thread control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go

p0lyn0mial commented Jan 14, 2026

View reviewed changes

p0lyn0mial force-pushed the om-phase-2-om-dyn-inf-stub branch 3 times, most recently from ab546fb to 29cde6f Compare January 16, 2026 11:31

p0lyn0mial force-pushed the om-phase-2-om-dyn-inf-stub branch from 29cde6f to b6fda8d Compare January 16, 2026 12:16

p0lyn0mial mentioned this pull request Jan 19, 2026

API-1835: Scaffold event dispatcher #7543

Closed

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2026

p0lyn0mial force-pushed the om-phase-2-om-dyn-inf-stub branch from b6fda8d to b153504 Compare January 19, 2026 13:51

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 20, 2026

p0lyn0mial force-pushed the om-phase-2-om-dyn-inf-stub branch from bd90b05 to 2a4b59b Compare January 20, 2026 11:27

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 20, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 20, 2026

coderabbitai Bot reviewed Jan 20, 2026

View reviewed changes

p0lyn0mial mentioned this pull request Jan 20, 2026

API-1835: intro dispatcher filters #7552

Closed

bertinatto reviewed Jan 20, 2026

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026

p0lyn0mial added 2 commits January 21, 2026 09:27

feat(openshiftmanager-phase2): bump deps

e47fe05

updated dependencies reqired by the changes introduced in 7477 PR.

p0lyn0mial force-pushed the om-phase-2-om-dyn-inf-stub branch from 2a4b59b to e47fe05 Compare January 21, 2026 08:28

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 21, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 21, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026

p0lyn0mial mentioned this pull request Jan 21, 2026

API-1835: wires event handlers for informers #7559

Closed

openshift-merge-bot Bot merged commit 3678760 into openshift:main Jan 21, 2026
21 checks passed

Uh oh!

Conversation

p0lyn0mial commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

p0lyn0mial commented Jan 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 16, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csrwng commented Jan 19, 2026

Uh oh!

openshift-ci Bot commented Jan 19, 2026

Uh oh!

p0lyn0mial commented Jan 19, 2026

Uh oh!

p0lyn0mial commented Jan 20, 2026

Uh oh!

openshift-ci-robot commented Jan 20, 2026

Uh oh!

p0lyn0mial commented Jan 20, 2026

Uh oh!

openshift-ci-robot commented Jan 20, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bertinatto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 20, 2026

Uh oh!

p0lyn0mial commented Jan 21, 2026

Uh oh!

openshift-ci-robot commented Jan 21, 2026

Uh oh!

p0lyn0mial commented Jan 21, 2026

Uh oh!

p0lyn0mial commented Jan 21, 2026

p0lyn0mial commented Jan 14, 2026 •

edited

Loading

openshift-ci-robot commented Jan 14, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jan 14, 2026 •

edited

Loading

openshift-ci-robot commented Jan 16, 2026 •

edited by openshift-ci Bot

Loading