API-1835: Scaffold OpenShiftManager controller - #7445
Conversation
|
@p0lyn0mial: This pull request references API-1835 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughAdds an openshiftmanager controller package stub and an OWNERS file. The controller file defines an exported Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
Comment |
8a92ae4 to
e5dc3b5
Compare
|
/assign @benluddy @csrwng @bertinatto |
e5dc3b5 to
4633acc
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: muraee, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/verified by @p0lyn0mial |
|
@p0lyn0mial: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
Reconciler will be responsible for integration with OpenShiftManager. This reconclier is experimental and will be disabled by default.
4633acc to
c2bf1d6
Compare
|
/verified by @p0lyn0mial |
|
@p0lyn0mial: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
had to rebase to make Konflux jobs happy |
|
/lgtm |
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
5b876b9
into
openshift:main
Scaffolds a Reconciler which will be responsible for integration with OpenShiftManager.
This controller is experimental and will be disabled by default.
For more information on OpenShiftManager, see
https://github.com/openshift/enhancements/blob/master/dev-guide/multi-operator-manager.md.