Skip to content

API-1835: Scaffold OpenShiftManager controller - #7445

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
p0lyn0mial:om-phase-2-om-ctrl-stub
Jan 14, 2026
Merged

API-1835: Scaffold OpenShiftManager controller#7445
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
p0lyn0mial:om-phase-2-om-ctrl-stub

Conversation

@p0lyn0mial

Copy link
Copy Markdown
Contributor

Scaffolds a Reconciler which will be responsible for integration with OpenShiftManager.
This controller is experimental and will be disabled by default.

For more information on OpenShiftManager, see
https://github.com/openshift/enhancements/blob/master/dev-guide/multi-operator-manager.md.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jan 8, 2026

Copy link
Copy Markdown

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Scaffolds a Reconciler which will be responsible for integration with OpenShiftManager.
This controller is experimental and will be disabled by default.

For more information on OpenShiftManager, see
https://github.com/openshift/enhancements/blob/master/dev-guide/multi-operator-manager.md.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Adds an openshiftmanager controller package stub and an OWNERS file. The controller file defines an exported Reconciler type and a SetupWithManager method that returns a "not implemented" error; OWNERS lists approvers and reviewers.

Changes

Cohort / File(s) Summary
OpenShift Manager controller package
control-plane-operator/controllers/openshiftmanager/OWNERS, control-plane-operator/controllers/openshiftmanager/openshiftmanager_controller.go
Adds OWNERS with approvers and reviewers. Introduces exported Reconciler struct and SetupWithManager(mgr ctrl.Manager) error method stub returning fmt.Errorf("not implemented"). Controller marked experimental/disabled by default.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 4633acc and c2bf1d6.

📒 Files selected for processing (2)
  • control-plane-operator/controllers/openshiftmanager/OWNERS
  • control-plane-operator/controllers/openshiftmanager/openshiftmanager_controller.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • control-plane-operator/controllers/openshiftmanager/OWNERS
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • control-plane-operator/controllers/openshiftmanager/openshiftmanager_controller.go
🔇 Additional comments (1)
control-plane-operator/controllers/openshiftmanager/openshiftmanager_controller.go (1)

1-19: Clean controller scaffold with appropriate documentation.

The stub follows standard controller-runtime patterns. The clear documentation about experimental status and the not implemented error in SetupWithManager are appropriate safeguards for a disabled-by-default controller scaffold.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
openshift-ci Bot requested review from devguyio and jparrill January 8, 2026 15:59
@openshift-ci openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jan 8, 2026
@p0lyn0mial
p0lyn0mial force-pushed the om-phase-2-om-ctrl-stub branch from 8a92ae4 to e5dc3b5 Compare January 8, 2026 16:00
@p0lyn0mial

Copy link
Copy Markdown
Contributor Author

/assign @benluddy @csrwng @bertinatto

@p0lyn0mial

p0lyn0mial commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

@muraee @sjenning since @csrwng is out please review this pr.

@p0lyn0mial
p0lyn0mial force-pushed the om-phase-2-om-ctrl-stub branch from e5dc3b5 to 4633acc Compare January 9, 2026 07:39
@muraee

muraee commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@benluddy

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@p0lyn0mial

Copy link
Copy Markdown
Contributor Author

/verified by @p0lyn0mial

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@p0lyn0mial: This PR has been marked as verified by @p0lyn0mial.

Details

In response to this:

/verified by @p0lyn0mial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD ed9c78c and 2 for PR HEAD 4633acc in total

@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD aa6f394 and 1 for PR HEAD 4633acc in total

@p0lyn0mial

Copy link
Copy Markdown
Contributor Author

/retest

Reconciler will be responsible for integration with OpenShiftManager.
This reconclier is experimental and will be disabled by default.
@p0lyn0mial
p0lyn0mial force-pushed the om-phase-2-om-ctrl-stub branch from 4633acc to c2bf1d6 Compare January 13, 2026 10:02
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 13, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@p0lyn0mial

Copy link
Copy Markdown
Contributor Author

/verified by @p0lyn0mial

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 13, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@p0lyn0mial: This PR has been marked as verified by @p0lyn0mial.

Details

In response to this:

/verified by @p0lyn0mial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial

Copy link
Copy Markdown
Contributor Author

had to rebase to make Konflux jobs happy

@muraee

muraee commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 2ff5e34 and 2 for PR HEAD c2bf1d6 in total

@p0lyn0mial

Copy link
Copy Markdown
Contributor Author

/test e2e-aws

1 similar comment
@p0lyn0mial

Copy link
Copy Markdown
Contributor Author

/test e2e-aws

@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 85068be and 1 for PR HEAD c2bf1d6 in total

@openshift-merge-bot
openshift-merge-bot Bot merged commit 5b876b9 into openshift:main Jan 14, 2026
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants