Skip to content

NO-JIRA: Remove kas from EnsureNoCrashingPods exceptions #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Apr 21, 2025
Merged

NO-JIRA: Remove kas from EnsureNoCrashingPods exceptions #5946

openshift-merge-bot merged 2 commits into from
Apr 21, 2025

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented Apr 1, 2025

This was introduced here #5871 It shouldn't be needed now #5937 is merged

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@enxebre
Copy link
Member Author

enxebre commented Apr 1, 2025

/test e2e-aws

@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Apr 1, 2025
@enxebre
Copy link
Member Author

enxebre commented Apr 2, 2025

/test e2e-aws

rtheis
rtheis approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 2, 2025
@jparrill
Copy link
Contributor

jparrill commented Apr 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2025
@enxebre
Copy link
Member Author

enxebre commented Apr 3, 2025

/test e2e-aws

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Apr 3, 2025

/test e2e-aws

@sjenning
Copy link
Contributor

sjenning commented Apr 4, 2025

On the latest run, seems that many (all?) KASes in all test clusters restarted

/hold

Until we get it figured out

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2025
@enxebre enxebre force-pushed the remove-kas-from-EnsureNoCrashingPods-exception branch from fc55b5e to 4b9dae5 Compare April 4, 2025 09:36
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@enxebre
Copy link
Member Author

enxebre commented Apr 4, 2025

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Apr 7, 2025

The bootstrap container is still restarting once for the previous version of the CP upgrade test.
We need to merge the polling first separately before enabling the restart check, so the previous version include the polling
#5990

@cwbotbot
Copy link

cwbotbot commented Apr 8, 2025 •
edited
Loading

Test Results

e2e-aws

Failed Tests

Total failed tests: 11

  • TestNodePool
  • TestNodePool/HostedCluster0
  • TestNodePool/HostedCluster0/Main
  • TestNodePool/HostedCluster0/Main/TestNTOMachineConfigGetsRolledOut
  • TestNodePool/HostedCluster0/Teardown

... and 6 more failed tests

e2e-aks

@enxebre enxebre force-pushed the remove-kas-from-EnsureNoCrashingPods-exception branch from 4b9dae5 to cc7edbb Compare April 9, 2025 07:59
@enxebre
Copy link
Member Author

enxebre commented Apr 9, 2025

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Apr 9, 2025 •
edited
Loading 

   --- FAIL: TestCreateClusterCustomConfigV2/ValidateHostedCluster/EnsureNoCrashingPods (0.02s)

This seems to have been a legit flake due to not polling long enough https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_hypershift/5946/pull-ci-openshift-hypershift-main-e2e-aws/1909878955062595584/artifacts/e2e-aws/hypershift-aws-run-e2e-external/artifacts/TestCreateClusterCustomConfigV2/namespaces/e2e-clusters-zflzc-custom-config-v2-zdcnl/core/pods/logs/kube-apiserver-67d988db7d-65vl4-bootstrap-previous.log
If confirmed I'll increase the polling time

/test e2e-aws

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Apr 9, 2025
@enxebre
Copy link
Member Author

enxebre commented Apr 9, 2025

seen more failure cases for create with custom config tests https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/5946/pull-ci-openshift-hypershift-main-e2e-aws/1909905171337449472

Added a commit to increase the poll interval.

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Apr 9, 2025

all green, retesting for flakes
/test e2e-aws

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2025
@enxebre enxebre force-pushed the remove-kas-from-EnsureNoCrashingPods-exception branch from 90e0332 to f76a1ac Compare April 15, 2025 10:54
@enxebre
Copy link
Member Author

enxebre commented Apr 15, 2025

Increased timeout to have a margin (50s) with kms setup times showed on CI runs (~38s).
Test passed.
Rerunning

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Apr 15, 2025

seems unrelated flakes https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/5946/pull-ci-openshift-hypershift-main-e2e-aws/1912147598190317568

/test e2e-aws

@enxebre
Copy link
Member Author

enxebre commented Apr 16, 2025

same unrelated flake in aws
/test e2e-aws
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2025
rtheis
rtheis approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2025

/retest-required

Remaining retests: 0 against base HEAD cddcc2f and 2 for PR HEAD f76a1ac in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2025

/retest-required

Remaining retests: 0 against base HEAD cddcc2f and 2 for PR HEAD f76a1ac in total

@rtheis
Copy link
Contributor

rtheis commented Apr 16, 2025

/retest

1 similar comment
@rtheis
Copy link
Contributor

rtheis commented Apr 17, 2025

/retest

@rtheis
Copy link
Contributor

rtheis commented Apr 17, 2025

/test e2e-aws

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025

/retest-required

Remaining retests: 0 against base HEAD 6f2ef2b and 2 for PR HEAD f76a1ac in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025

/retest-required

Remaining retests: 0 against base HEAD c7af495 and 2 for PR HEAD f76a1ac in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2025

/retest-required

Remaining retests: 0 against base HEAD 0145374 and 1 for PR HEAD f76a1ac in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2025

/retest-required

Remaining retests: 0 against base HEAD 97e19c3 and 2 for PR HEAD f76a1ac in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2025

/retest-required

Remaining retests: 0 against base HEAD 949da39 and 1 for PR HEAD f76a1ac in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2025
@enxebre
Remove kas from EnsureNoCrashingPods exceptions
b597610 
This was introduced here openshift#5871
It shouldn't be needed now openshift#5937 is merged
@enxebre enxebre force-pushed the remove-kas-from-EnsureNoCrashingPods-exception branch from f76a1ac to 6b1f90b Compare April 21, 2025 11:13
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2025
@enxebre enxebre force-pushed the remove-kas-from-EnsureNoCrashingPods-exception branch from 6b1f90b to 466036f Compare April 21, 2025 11:13
rtheis
rtheis approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2025

@enxebre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 466036f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5680016 into openshift:main Apr 21, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasueki hasueki Awaiting requested review from hasueki

1 more reviewer

@rtheis rtheis rtheis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jparrill jparrill

@rtheis rtheis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@enxebre @jparrill @sjenning @cwbotbot @openshift-ci-robot @rtheis @openshift-merge-robot