CNTRLPLANE-378: Move bootstrap apply bash into kas-bootstrap binary #5937

enxebre · 2025-03-31T10:52:54Z

What this PR does / why we need it:
Follow up for #5871
It aims to alleviate the current bash scripts fragility and cover existing and any upcoming changes to this logic with appropriate test coverage

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2025-03-31T10:52:58Z

@enxebre: This pull request references CNTRLPLANE-378 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-03-31T10:53:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre · 2025-03-31T10:53:42Z

cc @wking

bryan-cox · 2025-03-31T12:43:48Z

kas-bootstrap/main.go

+		ResourcesPath: "/work",
 	}
-	cmd.Flags().StringVar(&opts.RenderedFeatureGatePath, "rendered-featuregate-path", "", "The path to the rendered featureGate CR")
+	cmd.Flags().StringVar(&opts.ResourcesPath, "resources-path", "", "The path to the rendered featureGate CR to reconcile and all resources to apply")


nit: wording

Suggested change

cmd.Flags().StringVar(&opts.ResourcesPath, "resources-path", "", "The path to the rendered featureGate CR to reconcile and all resources to apply")

cmd.Flags().StringVar(&opts.ResourcesPath, "resources-path", "", "The path to the rendered featureGate CR to reconcile and apply all the resources.")

bryan-cox · 2025-03-31T13:08:37Z

/lgtm

Follow up for openshift#5871 It aims to alleviate the current bash scripts fragility and cover existing and any upcoming changes to this logic with appropriate test coverage

openshift-ci-robot · 2025-03-31T13:10:45Z

@enxebre: This pull request references CNTRLPLANE-378 which is a valid jira issue.

Details

In response to this:

What this PR does / why we need it:
Follow up for #5871
It aims to alleviate the current bash scripts fragility and cover existing and any upcoming changes to this logic with appropriate test coverage

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-03-31T14:59:20Z

/retest-required

Remaining retests: 0 against base HEAD 782dea3 and 2 for PR HEAD 89066ea in total

enxebre · 2025-03-31T15:10:22Z

/test e2e-aws

enxebre · 2025-03-31T15:10:45Z

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

openshift-ci · 2025-03-31T15:10:59Z

@enxebre: Overrode contexts on behalf of enxebre: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main, Red Hat Konflux / hypershift-operator-main-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

enxebre · 2025-03-31T17:26:38Z

/test e2e-aks

openshift-ci-robot · 2025-03-31T19:50:53Z

/retest-required

Remaining retests: 0 against base HEAD 782dea3 and 2 for PR HEAD 89066ea in total

openshift-ci · 2025-03-31T23:56:04Z

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2025-04-01T03:50:11Z

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.20.0-202504010243.p0.g616a2fa.assembly.stream.el9.
All builds following this will include this PR.

This was introduced here openshift#5871 It shouldn't be needed now openshift#5937 is merged

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2025

openshift-ci bot added the do-not-merge/needs-area label Mar 31, 2025

openshift-ci bot requested review from csrwng and hasueki March 31, 2025 10:53

openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Mar 31, 2025

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Mar 31, 2025

bryan-cox reviewed Mar 31, 2025

View reviewed changes

enxebre force-pushed the kas-bootstrap-followup branch from b4d2f8e to 8e980c1 Compare March 31, 2025 13:05

enxebre added 2 commits March 31, 2025 15:08

Add kas-bootstrap logic to apply resources

d5b44ef

Follow up for openshift#5871 It aims to alleviate the current bash scripts fragility and cover existing and any upcoming changes to this logic with appropriate test coverage

Drop bootstrap apply bash in favour of kas-bootstrap binary

89066ea

enxebre force-pushed the kas-bootstrap-followup branch from 8e980c1 to 89066ea Compare March 31, 2025 13:10

openshift-ci bot assigned bryan-cox Mar 31, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2025

enxebre mentioned this pull request Mar 31, 2025

OCPBUGS-46379: Kas bootstrap bin #5871

Merged

4 tasks

enxebre changed the title ~~CNTRLPLANE-378: Move bootstrap apply bas into kas-bootstrap binary~~ CNTRLPLANE-378: Move bootstrap apply bash into kas-bootstrap binary Mar 31, 2025

openshift-merge-bot bot merged commit 616a2fa into openshift:main Mar 31, 2025
14 of 16 checks passed

enxebre added a commit to enxebre/hypershift that referenced this pull request Apr 1, 2025

Remove kas from EnsureNoCrashingPods exceptions

30d2990

This was introduced here openshift#5871 It shouldn't be needed now openshift#5937 is merged

This was referenced Apr 1, 2025

NO-JIRA: Remove kas from EnsureNoCrashingPods exceptions #5946

Merged

CNTRLPLANE-378: Run kas-bootstrap binary for cpov2 #5947

Merged

enxebre added a commit to enxebre/hypershift that referenced this pull request Apr 9, 2025

Remove kas from EnsureNoCrashingPods exceptions

cc7edbb

This was introduced here openshift#5871 It shouldn't be needed now openshift#5937 is merged

enxebre added a commit to enxebre/hypershift that referenced this pull request Apr 21, 2025

Remove kas from EnsureNoCrashingPods exceptions

b597610

This was introduced here openshift#5871 It shouldn't be needed now openshift#5937 is merged

	cmd.Flags().StringVar(&opts.ResourcesPath, "resources-path", "", "The path to the rendered featureGate CR to reconcile and all resources to apply")
	cmd.Flags().StringVar(&opts.ResourcesPath, "resources-path", "", "The path to the rendered featureGate CR to reconcile and apply all the resources.")

CNTRLPLANE-378: Move bootstrap apply bash into kas-bootstrap binary #5937

CNTRLPLANE-378: Move bootstrap apply bash into kas-bootstrap binary #5937

Uh oh!

Conversation

enxebre commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 31, 2025

Uh oh!

enxebre commented Mar 31, 2025

Uh oh!

bryan-cox Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

bryan-cox commented Mar 31, 2025

Uh oh!

openshift-ci-robot commented Mar 31, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2025

Uh oh!

enxebre commented Mar 31, 2025

Uh oh!

enxebre commented Mar 31, 2025

Uh oh!

openshift-ci bot commented Mar 31, 2025

Uh oh!

enxebre commented Mar 31, 2025

Uh oh!

openshift-ci-robot commented Mar 31, 2025

Uh oh!

openshift-ci bot commented Mar 31, 2025

Uh oh!

Uh oh!

openshift-bot commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

enxebre commented Mar 31, 2025 •

edited

Loading

openshift-ci-robot commented Mar 31, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 31, 2025 •

edited by openshift-ci bot

Loading