NO-JIRA: test/e2e: improve VAP test assertions

[sjenning]

openshift/cluster-network-operator#2612 broke our e2e because our assertions in EnsureValidatingAdmissionPoliciesExists make the assumption that the only VAPs in the guest cluster are ones that we create.

The PR refactors this check to:

• Not assume no other VAPs exist
• Not wait for VAPs to exist as this is called from after(), as in after the HostedCluster is fully deployed and the VAPs should already be created. It is a bug if they are not created by the time the check runs.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sjenning: This pull request explicitly references no jira issue.

Details

In response to this:

openshift/cluster-network-operator#2612 broke our e2e because our assertions in EnsureValidatingAdmissionPoliciesExists make the assumption that the only VAPs in the guest cluster are ones that we create.

The PR refactors this check to:

• Not assume no other VAPs exist
• Does not wait for VAPs to exist as this is called from after(), as in after the HostedCluster is fully deployed and the VAPs should already be created. It is a bug if they are not created by the time the check runs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sjenning]

/test e2e-aws

[sjenning]

/retest

[sjenning]

self lgtm'ing and overriding to fix e2e
/override ci/prow/e2e-aws
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

[openshift-ci]

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws, ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

self lgtm'ing and overriding to fix e2e
/override ci/prow/e2e-aws
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202501110441.p0.ga39bf24.assembly.stream.el9.
All builds following this will include this PR.