OCPBUGS-42609: Disable adding/removing the UDN namespace label #2612

trozet · 2025-01-09T16:24:31Z

UDN namespace label will be required when namespaces are created in order to use a primary UDN in that namespace.

Upstream PR: ovn-kubernetes/ovn-kubernetes#4912

openshift-ci-robot · 2025-01-09T16:24:38Z

@trozet: This pull request references Jira Issue OCPBUGS-42609, which is invalid:

expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

UDN namespace label will be required when namespaces are created in order to use a primary UDN in that namespace.

Upstream PR: ovn-kubernetes/ovn-kubernetes#4912

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

trozet · 2025-01-09T16:25:26Z

/jira refresh

openshift-ci-robot · 2025-01-09T16:25:34Z

@trozet: This pull request references Jira Issue OCPBUGS-42609, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mohit-sheth

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2025-01-09T16:25:40Z

bindata/network/ovn-kubernetes/common/udn-admission-policy.yaml

+      - apiGroups:   [""]
+        apiVersions: ["v1"]
+        operations:  ["UPDATE"]
+        resources:   ["namespaces"]


NIT: missing an empty line

kyrtapz · 2025-01-09T16:25:54Z

bindata/network/ovn-kubernetes/common/udn-admission-policy.yaml

@@ -0,0 +1,30 @@
+apiVersion: admissionregistration.k8s.io/v1


We should only apply this if UDN is enabled

kyrtapz · 2025-01-09T16:33:55Z

bindata/network/ovn-kubernetes/common/udn-admission-policy.yaml

+apiVersion: admissionregistration.k8s.io/v1
+kind: ValidatingAdmissionPolicy
+metadata:
+  name: disable-udn-label-change


Can we make it more user friendly? something like:
user-defined-networks-namespace-label

trozet · 2025-01-09T22:32:20Z

/testwith ?

UDN namespace label will be required when namespaces are created in order to use a primary UDN in that namespace. Co-authored-by: Patryk Diak <pdiak@redhat.com> Signed-off-by: Tim Rozet <trozet@redhat.com>

kyrtapz · 2025-01-10T08:10:18Z

/retest

kyrtapz · 2025-01-10T11:40:27Z

/lgtm

openshift-ci · 2025-01-10T11:41:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kyrtapz,trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-01-10T12:03:08Z

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-hypershift-ovn-kubevirt	`4668f71`	link	false	`/test e2e-aws-hypershift-ovn-kubevirt`
ci/prow/security	`4668f71`	link	false	`/test security`
ci/prow/e2e-openstack-ovn	`4668f71`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	`4668f71`	link	false	`/test e2e-vsphere-ovn-dualstack-primaryv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

trozet · 2025-01-10T14:30:10Z

/label acknowledge-critical-fixes-only

openshift-ci-robot · 2025-01-10T14:34:00Z

@trozet: Jira Issue OCPBUGS-42609: Some pull requests linked via external trackers have merged:

openshift/cluster-network-operator#2612

The following pull requests linked via external trackers have not merged:

openshift/origin#29417 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-42609 has not been moved to the MODIFIED state.

Details

In response to this:

UDN namespace label will be required when namespaces are created in order to use a primary UDN in that namespace.

Upstream PR: ovn-kubernetes/ovn-kubernetes#4912

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-01-10T19:02:10Z

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.19.0-202501101641.p0.g2a17ab8.assembly.stream.el9.
All builds following this will include this PR.

openshift/cluster-network-operator#2612 introduced a new VAP to account for. Signed-off-by: Bryan Cox <brcox@redhat.com>

openshift-merge-robot · 2025-04-15T00:06:16Z

Fix included in accepted release 4.19.0-0.nightly-2025-04-02-065200

openshift-merge-robot · 2025-04-16T11:34:32Z

Fix included in accepted release 4.19.0-0.nightly-2025-04-02-170034

openshift-merge-robot · 2025-04-16T22:23:13Z

Fix included in accepted release 4.19.0-0.nightly-2025-04-04-023411

openshift-merge-robot · 2025-04-18T15:14:43Z

Fix included in accepted release 4.19.0-0.nightly-2025-04-04-170728

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2025

openshift-ci bot requested review from JacobTanenbaum and abhat January 9, 2025 16:25

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 9, 2025

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 9, 2025

openshift-ci bot requested a review from mohit-sheth January 9, 2025 16:25

kyrtapz reviewed Jan 9, 2025

View reviewed changes

trozet force-pushed the enforce_ns_udn_label branch from 97d773d to 215de3e Compare January 9, 2025 22:21

trozet mentioned this pull request Jan 9, 2025

OCPBUGS-42609: Updates UDN tests with required NS label openshift/origin#29417

Merged

trozet force-pushed the enforce_ns_udn_label branch from 215de3e to e6e69f5 Compare January 9, 2025 22:45

Disable adding/removing the UDN namespace label

4668f71

UDN namespace label will be required when namespaces are created in order to use a primary UDN in that namespace. Co-authored-by: Patryk Diak <pdiak@redhat.com> Signed-off-by: Tim Rozet <trozet@redhat.com>

trozet force-pushed the enforce_ns_udn_label branch from e6e69f5 to 4668f71 Compare January 9, 2025 22:53

openshift-ci bot assigned kyrtapz Jan 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 10, 2025

openshift-merge-bot bot merged commit 2a17ab8 into openshift:master Jan 10, 2025
31 of 35 checks passed

bryan-cox added a commit to bryan-cox/hypershift that referenced this pull request Jan 10, 2025

Increase the expected VAP count to 6

b9e643f

openshift/cluster-network-operator#2612 introduced a new VAP to account for. Signed-off-by: Bryan Cox <brcox@redhat.com>

neisw mentioned this pull request Jan 10, 2025

Revert "OCPBUGS-42609: Disable adding/removing the UDN namespace label" #2614

Closed

sjenning mentioned this pull request Jan 10, 2025

NO-JIRA: test/e2e: improve VAP test assertions openshift/hypershift#5375

Merged

openshift-ci-robot mentioned this pull request Jan 25, 2025

OCPBUGS-48330,OCPBUGS-42609,OCPBUGS-46585,SDN-4930,OCPBUGS-48412: Downstream Merge [01-23-2025] openshift/ovn-kubernetes#2420

Merged

OCPBUGS-42609: Disable adding/removing the UDN namespace label #2612

OCPBUGS-42609: Disable adding/removing the UDN namespace label #2612

Uh oh!

Conversation

trozet commented Jan 9, 2025

Uh oh!

openshift-ci-robot commented Jan 9, 2025

Uh oh!

trozet commented Jan 9, 2025

Uh oh!

openshift-ci-robot commented Jan 9, 2025

Uh oh!

kyrtapz Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

kyrtapz Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

kyrtapz Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

trozet commented Jan 9, 2025

Uh oh!

kyrtapz commented Jan 10, 2025

Uh oh!

kyrtapz commented Jan 10, 2025

Uh oh!

openshift-ci bot commented Jan 10, 2025

Uh oh!

openshift-ci bot commented Jan 10, 2025

Uh oh!

trozet commented Jan 10, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 10, 2025

Uh oh!

openshift-bot commented Jan 10, 2025

Uh oh!

openshift-merge-robot commented Apr 15, 2025

Uh oh!

openshift-merge-robot commented Apr 16, 2025

Uh oh!

openshift-merge-robot commented Apr 16, 2025

Uh oh!

openshift-merge-robot commented Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants