Skip to content

HOSTEDCP-1256: expose cert rotation scale parameter - #3208

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
stevekuznetsov:skuznets/cert-rotation-scale
Nov 21, 2023
Merged

HOSTEDCP-1256: expose cert rotation scale parameter#3208
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
stevekuznetsov:skuznets/cert-rotation-scale

Conversation

@stevekuznetsov

@stevekuznetsov stevekuznetsov commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

required for #3193

@openshift-ci openshift-ci Bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Nov 20, 2023
@stevekuznetsov
cmd/install: expose cert rotation scale parameter
9a90648 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
stevekuznetsov force-pushed the skuznets/cert-rotation-scale branch from 7103adb to 9a90648 Compare November 21, 2023 00:01
@openshift-ci openshift-ci Bot added the area/ci-tooling Indicates the PR includes changes for CI or tooling label Nov 21, 2023
@sjenning

sjenning commented Nov 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

/approve

looks like it still needs a make app-sre-saas-template

@openshift-ci

openshift-ci Bot commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@sjenning sjenning mentioned this pull request Nov 21, 2023
Merged
@sjenning

sjenning commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@stevekuznetsov

stevekuznetsov commented Nov 21, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor Author

/retitle HOSTEDCP-1256: expose cert rotation scale parameter

@openshift-ci openshift-ci Bot changed the title cmd/install: expose cert rotation scale parameter HOSTEDCP-1256: expose cert rotation scale parameter Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023
@openshift-ci-robot

openshift-ci-robot commented Nov 21, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@stevekuznetsov: This pull request references HOSTEDCP-1256 which is a valid jira issue.

Details

In response to this:

required for #3193

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci

openshift-ci Bot commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit bfa5df3 into openshift:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasueki hasueki Awaiting requested review from hasueki
@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@sjenning sjenning

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevekuznetsov @sjenning @openshift-ci-robot