Skip to content

CCO-388: control-plane-operator: reconcile the CCO #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Dec 18, 2023
Merged

CCO-388: control-plane-operator: reconcile the CCO #2794

openshift-merge-bot merged 3 commits into from
Dec 18, 2023

Conversation

@stevekuznetsov
Copy link
Contributor

@stevekuznetsov stevekuznetsov commented Jul 11, 2023

What this PR does / why we need it:

Adds CCO reconcilitation to the CPO.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from csrwng and sjenning July 11, 2023 14:22
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jul 11, 2023
gallettilance
gallettilance reviewed Jul 11, 2023
View reviewed changes
Copy link

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but looks great! Note to other reviewers: we'll need CCO-395 to land so that we can scale the CCO deployment per guest cluster.

stevekuznetsov
stevekuznetsov commented Jul 11, 2023
View reviewed changes
csrwng
csrwng reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@csrwng csrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

@netlify
Copy link

netlify bot commented Jul 14, 2023 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 08447d6
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65732dd6ef7d4f00088b1491
😎 Deploy Preview https://deploy-preview-2794--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Jul 14, 2023

/retest

Quota failures...

@stevekuznetsov stevekuznetsov force-pushed the skuznets/cco branch 5 times, most recently from 781f6f9 to 7bd3346 Compare July 17, 2023 16:24
@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label Jul 17, 2023
@stevekuznetsov stevekuznetsov changed the title control-plane-operator: reconcile the CCO CCO-388: control-plane-operator: reconcile the CCO Jul 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2023 •
edited by openshift-ci bot
Loading

@stevekuznetsov: This pull request references CCO-388 which is a valid jira issue.

Details

In response to this:

What this PR does / why we need it:

Adds CCO reconcilitation to the CPO.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Jul 17, 2023

Needs openshift/cloud-credential-operator#571

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Jul 17, 2023

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2023
@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Dec 7, 2023

/retest

@csrwng
Copy link
Contributor

csrwng commented Dec 8, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@stevekuznetsov stevekuznetsov force-pushed the skuznets/cco branch 2 times, most recently from 04ac7a5 to 8ceb79d Compare December 8, 2023 16:52
@csrwng
Copy link
Contributor

csrwng commented Dec 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 8, 2023

/retest-required

Remaining retests: 0 against base HEAD 6315b72 and 2 for PR HEAD 8ceb79d in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2023

/retest-required

Remaining retests: 0 against base HEAD bcb3e90 and 1 for PR HEAD 8ceb79d in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2023

/retest-required

Remaining retests: 0 against base HEAD 0952c61 and 0 for PR HEAD 8ceb79d in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2023

/hold

Revision 8ceb79d was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Dec 15, 2023

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@csrwng
Copy link
Contributor

csrwng commented Dec 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Dec 18, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 0667a89 into openshift:main Dec 18, 2023
@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Dec 19, 2023

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 19, 2023

@stevekuznetsov: new pull request created: #3336

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre enxebre left review comments

@csrwng csrwng csrwng left review comments

@sjenning sjenning Awaiting requested review from sjenning

+1 more reviewer

@gallettilance gallettilance gallettilance left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@csrwng csrwng

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@stevekuznetsov @openshift-ci-robot @sjenning @openshift-bot @enxebre @csrwng @openshift-cherrypick-robot @gallettilance @openshift-merge-robot