Skip to content

Conversation

@stevekuznetsov
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2023

@stevekuznetsov: This pull request references CCO-388 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jstuever and suhanime July 17, 2023 19:01
@stevekuznetsov
Copy link
Contributor Author

Needs openshift/api#1528

@abutcher
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@stevekuznetsov stevekuznetsov force-pushed the skuznets/add-crd-to-hcp branch from 85b0e35 to 8ba1bb9 Compare July 17, 2023 19:18
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #571 (0c30382) into master (5104bd4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   47.72%   47.72%           
=======================================
  Files          93       93           
  Lines       11682    11682           
=======================================
  Hits         5575     5575           
  Misses       5480     5480           
  Partials      627      627           
Impacted Files Coverage Δ
pkg/assets/bootstrap/bindata.go 23.85% <ø> (ø)

Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/add-crd-to-hcp branch from 98d7a99 to 0c30382 Compare July 17, 2023 19:57
@abutcher
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5104bd4 and 2 for PR HEAD 0c30382 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 798b771 into openshift:master Jul 17, 2023
ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
…-to-hcp

CCO-388: manifests: add cloudcredentials.operator.openshift.io to HCP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants