api/v1beta1/hosted_controlplane: Godocs for ReleaseImage and IssuerURL #2048
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
These made it into v1alpha1 via b758e90 (Fixing some doc typos and issues, 2022-09-26, openshift#1742), with the following timeline: * 2022-08-25, 1703 opened adding v1beta1 [1]. * 2022-09-13, 1742 opened adjusting v1alpha1 Godocs [2]. * 2022-10-18, 1742 merged [3]. * 2022-11-29, 1703 merged [4]. Ideally 1703 would have rebased and picked up any intervening v1apha1 improvements before merging, but it missed these (and possibly more?), so I'm catching it up now. [1]: openshift#1703 (comment) [2]: openshift#1742 (comment) [3]: openshift#1742 (comment) [4]: openshift#1703 (comment)
wking
force-pushed
the
HostedControlPlane-ReleaseImage-godocs
branch
from
b68ffbb to
ab8b4d3
Compare
wking
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
These made it into v1alpha1 via b758e90 (#1742), with the following timeline:
Ideally 1703 would have rebased and picked up any intervening v1apha1 improvements before merging, but it missed these (and possibly more?), so I'm catching it up now.