Introduce v1beta1 API version #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
imain
reviewed
Aug 25, 2022
Contributor
imain
left a comment
imain
left a comment
There was a problem hiding this comment.
Looks like a very nice cleanup!
| // | ||
| // +optional | ||
| // +kubebuilder:default=s922 | ||
| SystemType string `json:"systemType,omitempty"` |
Contributor
There was a problem hiding this comment.
Should this have an enum validation?
openshift-merge-robot
added
the
needs-rebase
csrwng
force-pushed
the
v1beta1_version
branch
from
35601f1 to
6e56a87
Compare
openshift-merge-robot
removed
the
needs-rebase
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
csrwng
force-pushed
the
v1beta1_version
branch
2 times, most recently
from
4ef575a to
44021e2
Compare
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
csrwng
force-pushed
the
v1beta1_version
branch
8 times, most recently
from
9c3eceb to
fd3fe51
Compare
Contributor
Author
|
/close |
Contributor
|
@csrwng: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/reopen |
Contributor
|
@csrwng: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/retest-required |
csrwng
force-pushed
the
v1beta1_version
branch
from
4fd8520 to
8fe5a05
Compare
openshift-merge-robot
removed
the
needs-rebase
Member
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
csrwng
force-pushed
the
v1beta1_version
branch
from
8fe5a05 to
f87ef32
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
Author
|
/retest-required |
csrwng
force-pushed
the
v1beta1_version
branch
2 times, most recently
from
4cf402a to
92170e0
Compare
Adds code to convert from v1alpha1 to v1beta1 Updates code to use the new version
csrwng
force-pushed
the
v1beta1_version
branch
from
92170e0 to
89d3c80
Compare
Member
|
/lgtm |
Contributor
Author
|
/retest-required |
Contributor
|
@csrwng: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
added a commit
to wking/hypershift
that referenced
this pull request
Jan 17, 2023
These made it into v1alpha1 via b758e90 (Fixing some doc typos and issues, 2022-09-26, openshift#1742), with the following timeline: * 2022-08-25, 1703 opened adding v1beta1 [1]. * 2022-09-13, 1742 opened adjusting v1alpha1 Godocs [2]. * 2022-10-18, 1742 merged [3]. * 2022-11-29, 1703 merged [4]. Ideally 1703 would have rebased and picked up any intervening v1apha1 improvements before merging, but it missed these (and possibly more?), so I'm catching it up now. [1]: openshift#1703 (comment) [2]: openshift#1742 (comment) [3]: openshift#1742 (comment) [4]: openshift#1703 (comment)
wking
added a commit
to wking/hypershift
that referenced
this pull request
Jan 17, 2023
These made it into v1alpha1 via b758e90 (Fixing some doc typos and issues, 2022-09-26, openshift#1742), with the following timeline: * 2022-08-25, 1703 opened adding v1beta1 [1]. * 2022-09-13, 1742 opened adjusting v1alpha1 Godocs [2]. * 2022-10-18, 1742 merged [3]. * 2022-11-29, 1703 merged [4]. Ideally 1703 would have rebased and picked up any intervening v1apha1 improvements before merging, but it missed these (and possibly more?), so I'm catching it up now. [1]: openshift#1703 (comment) [2]: openshift#1742 (comment) [3]: openshift#1742 (comment) [4]: openshift#1703 (comment)
wking
added a commit
to wking/hypershift
that referenced
this pull request
Jan 18, 2023
These made it into v1alpha1 via b758e90 (Fixing some doc typos and issues, 2022-09-26, openshift#1742), with the following timeline: * 2022-08-25, 1703 opened adding v1beta1 [1]. * 2022-09-13, 1742 opened adjusting v1alpha1 Godocs [2]. * 2022-10-18, 1742 merged [3]. * 2022-11-29, 1703 merged [4]. Ideally 1703 would have rebased and picked up any intervening v1apha1 improvements before merging, but it missed these (and possibly more?), so I'm catching it up now. [1]: openshift#1703 (comment) [2]: openshift#1742 (comment) [3]: openshift#1742 (comment) [4]: openshift#1703 (comment)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds code to convert from v1alpha1 to v1beta1
Updates code to use the new version
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Ref https://issues.redhat.com/browse/HOSTEDCP-512
Checklist