HIVE-2550,HIVE-2551: AWS deprov job compliant with cred proc

[celebdor]

In #2322, in order to fix AWS provisioining in STS mode we pointed the credential_process configuration to /output/hiveutil. The problem is that the same configuration is used for both provisioning and deprovisioning. Thus, when trying to deprovision in STS mode, when it came time for delegating operation to hiveutil, we'd get an:

/output/hiveutil not found

This commit fixes it by replicating the /output/hiveutil existance for deprovisioning in AWS (though it will only get used in STS mode).

[openshift-ci-robot]

@celebdor: This pull request references HIVE-2551 which is a valid jira issue.

Details

In response to this:

In #2322, in order to fix AWS provisioining in STS mode we pointed the credential_process configuration to /output/hiveutil. The problem is that the same configuration is used for both provisioning and deprovisioning. Thus, when trying to deprovision in STS mode, when it came time for delegating operation to hiveutil, we'd get an:

/output/hiveutil not found

This commit fixes it by replicating the /output/hiveutil existance for deprovisioning in AWS (though it will only get used in STS mode).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.57%. Comparing base (73c38b4) to head (03ed534).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2325      +/-   ##
==========================================
+ Coverage   58.54%   58.57%   +0.03%     
==========================================
  Files         182      182              
  Lines       25843    25863      +20     
==========================================
+ Hits        15130    15150      +20     
  Misses       9437     9437              
  Partials     1276     1276              

Files	Coverage Δ
pkg/install/generate.go	49.47% <100.00%> (+1.84%)	⬆️

[openshift-ci-robot]

@celebdor: An error was encountered searching for bug HIVE-2551 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 401:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

In #2322, in order to fix AWS provisioining in STS mode we pointed the credential_process configuration to /output/hiveutil. The problem is that the same configuration is used for both provisioning and deprovisioning. Thus, when trying to deprovision in STS mode, when it came time for delegating operation to hiveutil, we'd get an:

/output/hiveutil not found

This commit fixes it by replicating the /output/hiveutil existance for deprovisioning in AWS (though it will only get used in STS mode).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@celebdor: This pull request references HIVE-2550 which is a valid jira issue.

Details

In response to this:

In #2322, in order to fix AWS provisioining in STS mode we pointed the credential_process configuration to /output/hiveutil. The problem is that the same configuration is used for both provisioning and deprovisioning. Thus, when trying to deprovision in STS mode, when it came time for delegating operation to hiveutil, we'd get an:

/output/hiveutil not found

This commit fixes it by replicating the /output/hiveutil existance for deprovisioning in AWS (though it will only get used in STS mode).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lleshchi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, lleshchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lleshchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 73c38b4 and 2 for PR HEAD 03ed534 in total

[lleshchi]

/override "Red Hat Konflux / hive-on-pull-request"

[openshift-ci]

@lleshchi: Overrode contexts on behalf of lleshchi: Red Hat Konflux / hive-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / hive-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lleshchi]

/override "ci/prow/periodic-images"

[openshift-ci]

@lleshchi: Overrode contexts on behalf of lleshchi: ci/prow/periodic-images

Details

In response to this:

/override "ci/prow/periodic-images"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@celebdor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.