Fix AWS STS for RHEL8/9 transition#2322
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
In openshift#2260 we changed how we're invoking the openshift-install binary. Before: Copy openshift-install into the hive container and run it via `/usr/bin/hiveutil install-manager` After: Copy hiveutil into the installer container and run installer via `/output/hiveutil.rhel$VER install-manager` What we missed was that, for STS flows, we inject an AWS credentials file containing a `credential_process` that invoked `/usr/bin/hiveutil install-manager aws-credentials` -- but `hiveutil` no longer lives there. Fix. HIVE-2400
2uasimojo
force-pushed
the
HIVE-2400/fix-sts
branch
from
e99dc67 to
6355794
Compare
|
/test periodic-images Mysterious error message, may or may not be related to recent dockerfile changes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2322 +/- ##
=======================================
Coverage 58.54% 58.54%
=======================================
Files 182 182
Lines 25843 25843
=======================================
Hits 15130 15130
Misses 9437 9437
Partials 1276 1276
|
|
/cherry-pick mce-2.6 |
|
@2uasimojo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@2uasimojo: new pull request created: #2324 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In openshift#2322, in order to fix AWS provisioining in STS mode we pointed the credential_process configuration to /output/hiveutil. The problem is that the same configuration is used for both provisioning and deprovisioning. Thus, when trying to deprovision in STS mode, when it came time for delegating operation to hiveutil, we'd get an: /output/hiveutil not found This commit fixes it by replicating the /output/hiveutil existance for deprovisioning in AWS (though it will only get used in STS mode). Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
In openshift#2322, in order to fix AWS provisioining in STS mode we pointed the credential_process configuration to /output/hiveutil. The problem is that the same configuration is used for both provisioning and deprovisioning. Thus, when trying to deprovision in STS mode, when it came time for delegating operation to hiveutil, we'd get an: /output/hiveutil not found This commit fixes it by replicating the /output/hiveutil existance for deprovisioning in AWS (though it will only get used in STS mode). Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
In openshift#2322, in order to fix AWS provisioining in STS mode we pointed the credential_process configuration to /output/hiveutil. The problem is that the same configuration is used for both provisioning and deprovisioning. Thus, when trying to deprovision in STS mode, when it came time for delegating operation to hiveutil, we'd get an: /output/hiveutil not found This commit fixes it by replicating the /output/hiveutil existance for deprovisioning in AWS (though it will only get used in STS mode). Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
2 participants
In #2260 we changed how we're invoking the openshift-install binary.
Before: Copy openshift-install into the hive container and run it via
/usr/bin/hiveutil install-managerAfter: Copy hiveutil into the installer container and run installer via
/output/hiveutil.rhel$VER install-managerWhat we missed was that, for STS flows, we inject an AWS credentials file containing a
credential_processthat invoked/usr/bin/hiveutil install-manager aws-credentials-- buthiveutilno longer lives there.Fix.
HIVE-2400