Skip to content

machinepool: sort ownedLabels, ownedTaints#2313

Merged
2uasimojo merged 1 commit intoopenshift:masterfrom
2uasimojo:HIVE-2541/sort-owned-labels-taints
Jun 14, 2024
Merged

machinepool: sort ownedLabels, ownedTaints#2313
2uasimojo merged 1 commit intoopenshift:masterfrom
2uasimojo:HIVE-2541/sort-owned-labels-taints

Conversation

@2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Jun 14, 2024

With these unsorted, it was possible to thrash MachinePools.

HIVE-2541

With these unsorted, it was possible to thrash MachinePools.

HIVE-2541
@openshift-ci openshift-ci bot requested review from dlom and jstuever June 14, 2024 22:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@2uasimojo
Copy link
Member Author

/assign @suhanime

@dustman9000
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2uasimojo
Copy link
Member Author

verify being fixed via #2311
/override ci/prow/verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/verify

Details

In response to this:

verify being fixed via #2311
/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo 2uasimojo merged commit 47df0d9 into openshift:master Jun 14, 2024
@2uasimojo 2uasimojo deleted the HIVE-2541/sort-owned-labels-taints branch June 14, 2024 23:04
@2uasimojo
Copy link
Member Author

We'll want to backport this.

@2uasimojo
Copy link
Member Author

/cherry-pick mce-2.6 mce-2.5 mce-2.4

owned labels and taints start at 2.4

@openshift-cherrypick-robot

@2uasimojo: new pull request created: #2314

Details

In response to this:

/cherry-pick mce-2.6 mce-2.5 mce-2.4

owned labels and taints start at 2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants