Skip to content

HIVE-2400: fix obsolete python references#2311

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
celebdor:HIVE-2400-fix-python-refs
Jun 17, 2024
Merged

HIVE-2400: fix obsolete python references#2311
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
celebdor:HIVE-2400-fix-python-refs

Conversation

@celebdor
Copy link
Contributor

New builder images do not alias python to python3

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 14, 2024

@celebdor: This pull request references HIVE-2400 which is a valid jira issue.

Details

In response to this:

New builder images do not alias python to python3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lleshchi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot requested review from 2uasimojo and jstuever June 14, 2024 20:54
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[efried@efried hive]$ git grepv python
Makefile:SOURCE_GIT_TAG := $(shell export HOME=$(HOME); python3 -mpip install --user gitpython >&2; hack/version2.py)
docs/using-hive.md:      deploy_kernel_url: "http://172.22.0.3:6180/images/ironic-python-agent.kernel"
docs/using-hive.md:      deploy_ramdisk_url: "http://172.22.0.3:6180/images/ironic-python-agent.initramfs"
hack/app-sre/generate-saas-template.py:#!/usr/bin/env python
hack/bundle-gen.py:#!/usr/bin/env python
hack/statuspatch:python -c "import os, socket as s; s.socket(s.AF_UNIX).bind('$socket')"
hack/version2.py:#!/usr/bin/env python3

/lgtm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 23249e8 and 2 for PR HEAD 2ee6d59 in total

@celebdor celebdor force-pushed the HIVE-2400-fix-python-refs branch from 2ee6d59 to 18a269e Compare June 14, 2024 21:38
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@celebdor celebdor force-pushed the HIVE-2400-fix-python-refs branch from 18a269e to e1707c4 Compare June 14, 2024 22:05
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
New builder images do not alias python to python3

Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
@celebdor celebdor force-pushed the HIVE-2400-fix-python-refs branch from e1707c4 to 3d859ba Compare June 14, 2024 22:35
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 23249e8 and 2 for PR HEAD e1707c4 in total

Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, celebdor, lleshchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

@celebdor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4301922 into openshift:master Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants