Resolve dependabot issues 8-14 #1965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have transitive dependencies to golang.org/x/net and golang.org/x/text that are affected by the dependabot issues listed below. Rather than waiting for upstream dependencies to resolve the issues, we just blat in a whole passel of `replace` directives to get the bad versions out of our go.sum files. golang.org/x/net: - https://github.com/openshift/hive/security/dependabot/8 - https://github.com/openshift/hive/security/dependabot/9 - https://github.com/openshift/hive/security/dependabot/10 - https://github.com/openshift/hive/security/dependabot/12 - https://github.com/openshift/hive/security/dependabot/13 golang.org/x/text: - https://github.com/openshift/hive/security/dependabot/11 - https://github.com/openshift/hive/security/dependabot/14
Member
Author
|
/assign @abutcher |
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1965 +/- ##
=======================================
Coverage 40.71% 40.71%
=======================================
Files 367 367
Lines 34240 34240
=======================================
Hits 13940 13940
Misses 19091 19091
Partials 1209 1209 |
We resolved dependabot issues (see previous commit) by using a new-to-us syntax for the `replace` directive in go.mod, where the left-hand side of the arrow -- the version being replaced -- is specified at a particular version. Our `modcheck` utility was not set up to handle this properly: it was only using the library path as a map key for the structures used to compare the two go.mod files. Fortunately, this resulted in spurious failures; if the last replacement for a given library happened to match between the two files, we wouldn't have noticed. This commit resolves the issue by including the replaced library's version, if specified, in the map key used to compare the two go.mod files. Thus all replacements for a given library are present in the maps when we compare them, rather than just the last one.
Contributor
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, abutcher The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Mar 6, 2023
Commit acc096f in openshift#1965 added a bunch of `replace` directives to scrub library versions with known vulnerabilities out of go.sum. Turns out dependabot doesn't actually care about those -- just the ones in go.mod -- so remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have transitive dependencies to golang.org/x/net and golang.org/x/text that are affected by the dependabot issues listed below. Rather than waiting for upstream dependencies to resolve the issues, we just blat in a whole passel of
replacedirectives to get the bad versions out of our go.sum files.golang.org/x/net:
golang.org/x/text: