Skip to content

Conversation

@abutcher
Copy link
Member

@abutcher abutcher commented Mar 1, 2023

Bump golang.org/x/net from v0.5.0 to v0.7.0 to address:

This change intentionally leaves many references to previous versions of affected modules in go.sum as a test. The above dependabot issues may not be closed by this PR and if they are not closed by this PR then I will create a followup similar to openshift/hive#1965 which includes replaces for those versions.

Changes based on #511 which should be merged first.

@openshift-ci openshift-ci bot requested review from 2uasimojo and lleshchi March 1, 2023 16:20
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #517 (6a6ba6e) into master (65ec23a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files          94       94           
  Lines       10100    10100           
=======================================
  Hits         4814     4814           
  Misses       4713     4713           
  Partials      573      573           

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2023
@abutcher abutcher force-pushed the cco-xnet-dependabot branch from 7b0a357 to 6a6ba6e Compare March 2, 2023 18:43
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2023
@2uasimojo
Copy link
Member

Okay, I don't understand how dependabot is doing whatever it's doing, but if this is all we need to resolve the issues, I'm for it.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, abutcher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abutcher
Copy link
Member Author

abutcher commented Mar 2, 2023

/retest

@abutcher
Copy link
Member Author

abutcher commented Mar 2, 2023

/test e2e-upgrade

@2uasimojo
Copy link
Member

/retest

@2uasimojo
Copy link
Member

/test e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abutcher
Copy link
Member Author

abutcher commented Mar 3, 2023

Adding labels for vendor bump.

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Mar 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7a6fead into openshift:master Mar 3, 2023
@abutcher abutcher deleted the cco-xnet-dependabot branch March 3, 2023 18:37
@2uasimojo
Copy link
Member

/cherry-pick release-4.13

@openshift-cherrypick-robot

@2uasimojo: new pull request created: #543

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants