Revert hiveutil create-cluster's default AWS volumeType back to gp2.

[abutcher]

#1806 updated the default volume type for install config MachinePools (created by hiveutil create-cluster) to gp3. Alas, installers at and before 4.9 don't know about this type, so trying to install OpenShift at those versions results in the following error:

Error: expected root_block_device.0.volume_type to be one of [standard io1 gp2 sc1 st1], got gp3

We can effectively use the previous default volume type of gp2 which provides a baseline minimum of 100 iops and I have tested that the gp2 volumeType can be used with 4.8->4.11 installers.

The gp3 volume type performs better and is cheaper. It would be preferable to use gp3 as the default volumeType but Hive's clusterresourcebuilder can't make decisions based on the cluster version at present so I think Hive's default should use gp2 w/ no configured iops as the common denominator.

HIVE-1958

[2uasimojo]

It would be preferable to use gp3 as the default volumeType

But the consumer can always set it explicitly, right?

[2uasimojo]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, abutcher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo,abutcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abutcher]

It would be preferable to use gp3 as the default volumeType

But the consumer can always set it explicitly, right?

Yes, unless they are using clusterpools then the user would need clusterpool inventory to make a modificaton, correct?

[2uasimojo]

Yes, unless they are using clusterpools then the user would need clusterpool inventory to make a modificaton, correct?

It's in the install-config, right? In which case they can set it as the "default" for their whole pool.

(Twiddling it per pool cluster would require inventory, yes. But that's not a great use case for clusterpools or inventory. Better to use different pools.)

[abutcher]

It's in the install-config, right? In which case they can set it as the "default" for their whole pool.

Right.

[codecov]

Codecov Report

Merging #1836 (021b6dd) into master (7a98d30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   41.58%   41.58%           
=======================================
  Files         355      355           
  Lines       33139    33139           
=======================================
  Hits        13782    13782           
  Misses      18194    18194           
  Partials     1163     1163           

Impacted Files	Coverage Δ
pkg/clusterresource/aws.go	90.62% <ø> (-0.29%)	⬇️
...shift/hive/apis/hive/v1/clusterdeployment_types.go	50.00% <0.00%> (+16.66%)	⬆️

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD e318d38 and 8 for PR HEAD 021b6dd in total

[openshift-ci]

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.