Skip to content

Conversation

@abutcher
Copy link
Member

@abutcher abutcher commented Jun 22, 2022

openshift/installer#5925 introduces checks which disallow our previous hiveutil default of a gp2 volumeType with 100 IOPS as it was an incorrect configuration. From the linked change, IOPS may now only be set for io1, io2, & gp3 volume types.

HIVE-1914

openshift/installer#5925 introduces checks
which disallow our previous default of a gp2 volumeType with 100 IOPS
as it was an incorrect configuration. From the linked change, IOPS may
now only be set for io1, io2, & gp3 volume types.
@openshift-ci openshift-ci bot requested review from 2uasimojo and akhil-rane June 22, 2022 18:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
Copy link
Contributor

@akhil-rane akhil-rane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, akhil-rane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abutcher,akhil-rane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1806 (4e2e4c6) into master (7135d78) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
+ Coverage   41.72%   41.83%   +0.11%     
==========================================
  Files         353      353              
  Lines       33033    33075      +42     
==========================================
+ Hits        13782    13837      +55     
+ Misses      18097    18085      -12     
+ Partials     1154     1153       -1     
Impacted Files Coverage Δ
pkg/clusterresource/aws.go 90.90% <ø> (ø)
pkg/clusterresource/builder.go 73.28% <0.00%> (+6.90%) ⬆️

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2022

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants