Skip to content

CFE-1038: update command-line argument name for RouteExternalCertificate feature-gate #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 15, 2024
Merged

CFE-1038: update command-line argument name for RouteExternalCertificate feature-gate #1624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions enhancements/ingress/route-secret-injection-for-external-certificate-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ approvers:
api-approvers: # In case of new or modified APIs or API extensions (CRDs, aggregated apiservers, webhooks, finalizers). If there is no API change, use "None"
- '@joelspeed'
creation-date: 2022-12-13
last-updated: 2023-07-28
last-updated: 2024-05-14
tracking-link: # link to the tracking ticket (for example: Jira Feature or Epic ticket) that corresponds to this enhancement
- https://issues.redhat.com/browse/CM-815
---
Expand Down Expand Up @@ -241,7 +241,7 @@ use the default certificates only when `.spec.tls.certificate/key` or `.spec.tls
are not provided.

The cluster-ingress-operator will propagate the relevant Tech-Preview feature gate down to the
router. This feature gate will be added as a command-line argument called `ROUTER_EXTERNAL_CERTIFICATE`
router. This feature gate will be added as a command-line argument called `ROUTER_ENABLE_EXTERNAL_CERTIFICATE`
to the router and will not be user configurable.

### Risks and Mitigations
Expand Down