CFE-1038: update command-line argument name for RouteExternalCertificate feature-gate#1624
Conversation
Signed-off-by: chiragkyal <ckyal@redhat.com>
|
@chiragkyal: This pull request references CFE-1038 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @alebedev87 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@chiragkyal: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update command-line argument name to
ROUTER_ENABLE_EXTERNAL_CERTIFICATEfor RouteExternalCertificate feature-gateAs per openshift/cluster-ingress-operator#1017 (comment), we're using
ROUTER_ENABLE_EXTERNAL_CERTIFICATEenv var, instead ofROUTER_EXTERNAL_CERTIFICATEto propagate the Tech-Preview feature gate information down to router from cluster-ingress-operator.https://issues.redhat.com/browse/CFE-1038