Skip to content

Comments

CFE-1038: update command-line argument name for RouteExternalCertificate feature-gate#1624

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
chiragkyal:CFE-1038
May 15, 2024
Merged

CFE-1038: update command-line argument name for RouteExternalCertificate feature-gate#1624
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
chiragkyal:CFE-1038

Conversation

@chiragkyal
Copy link
Member

Update command-line argument name to ROUTER_ENABLE_EXTERNAL_CERTIFICATE for RouteExternalCertificate feature-gate

As per openshift/cluster-ingress-operator#1017 (comment), we're using ROUTER_ENABLE_EXTERNAL_CERTIFICATE env var, instead of ROUTER_EXTERNAL_CERTIFICATE to propagate the Tech-Preview feature gate information down to router from cluster-ingress-operator.

https://issues.redhat.com/browse/CFE-1038

Signed-off-by: chiragkyal <ckyal@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024

@chiragkyal: This pull request references CFE-1038 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Update command-line argument name to ROUTER_ENABLE_EXTERNAL_CERTIFICATE for RouteExternalCertificate feature-gate

As per openshift/cluster-ingress-operator#1017 (comment), we're using ROUTER_ENABLE_EXTERNAL_CERTIFICATE env var, instead of ROUTER_EXTERNAL_CERTIFICATE to propagate the Tech-Preview feature gate information down to router from cluster-ingress-operator.

https://issues.redhat.com/browse/CFE-1038

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Miciah and candita May 14, 2024 11:40
@chiragkyal
Copy link
Member Author

/assign @alebedev87

@alebedev87
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5a55b3b into openshift:master May 15, 2024
@chiragkyal chiragkyal deleted the CFE-1038 branch May 15, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants