Skip to content

Bug 2065689: Revert "UPSTREAM: docker/distribution: 3497: Support authentication using gcp workload identity federation"#28

Merged
openshift-merge-robot merged 1 commit intoopenshift:image-registry-4.7-distribution-2461543from
dmage:revert-26-support_gcp_workload_identity
Mar 24, 2022
Merged

Bug 2065689: Revert "UPSTREAM: docker/distribution: 3497: Support authentication using gcp workload identity federation"#28
openshift-merge-robot merged 1 commit intoopenshift:image-registry-4.7-distribution-2461543from
dmage:revert-26-support_gcp_workload_identity

Conversation

@dmage
Copy link

@dmage dmage commented Mar 17, 2022

Reverts #26

@openshift-ci openshift-ci bot requested review from adambkaplan and bparees March 17, 2022 13:17
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@deads2k
Copy link

deads2k commented Mar 17, 2022

now to figure out how to combined with openshift/origin#26918 and test

/hold

holding so we don't merge this by accident.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
@dmage
Copy link
Author

dmage commented Mar 23, 2022

/assign @akhil-rane @deads2k
Should we merge it?

@dmage dmage changed the title Revert "UPSTREAM: docker/distribution: 3497: Support authentication using gcp workload identity federation" Bug 2065689: Revert "UPSTREAM: docker/distribution: 3497: Support authentication using gcp workload identity federation" Mar 23, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Mar 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

@dmage: This pull request references Bugzilla bug 2065689, which is invalid:

  • expected Bugzilla bug 2065689 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2065689: Revert "UPSTREAM: docker/distribution: 3497: Support authentication using gcp workload identity federation"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 23, 2022
@dmage
Copy link
Author

dmage commented Mar 23, 2022

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

@dmage: This pull request references Bugzilla bug 2065689, which is invalid:

  • expected Bugzilla bug 2065689 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link

deads2k commented Mar 23, 2022

We're going with this approach

/lgtm
/hold cancel

@sdodson
Copy link
Member

sdodson commented Mar 23, 2022

/bugzilla refresh
/lgtm
/hold cancel
Seems like the bots took a break.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

@sdodson: This pull request references Bugzilla bug 2065689, which is invalid:

  • expected Bugzilla bug 2065689 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh
/lgtm
/hold cancel
Seems like the bots took a break.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dmage, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2022

@openshift-bot: This pull request references Bugzilla bug 2065689, which is invalid:

  • expected Bugzilla bug 2065689 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit edc8e10 into openshift:image-registry-4.7-distribution-2461543 Mar 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2022

@dmage: All pull requests linked via external trackers have merged:

Bugzilla bug 2065689 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2065689: Revert "UPSTREAM: docker/distribution: 3497: Support authentication using gcp workload identity federation"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments