UPSTREAM: docker/distribution: 3497: Support authentication using gcp workload identity federation#26
Merged
openshift-merge-robot merged 2 commits intoopenshift:image-registry-4.7-distribution-2461543from Sep 13, 2021
akhil-rane:support_gcp_workload_identity
Merged
UPSTREAM: docker/distribution: 3497: Support authentication using gcp workload identity federation#26openshift-merge-robot merged 2 commits intoopenshift:image-registry-4.7-distribution-2461543from akhil-rane:support_gcp_workload_identity
openshift-merge-robot merged 2 commits intoopenshift:image-registry-4.7-distribution-2461543from
akhil-rane:support_gcp_workload_identity
Conversation
New short lived credentials for workload identity have different type called 'external_account'. Current code does not support this type.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
akhil-rane
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@akhil-rane please add a link for the upstream PR in description. |
akhil-rane
changed the title
Author
addressed. PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akhil-rane, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
openshift-merge-robot
merged commit 30f7a83
into
openshift:image-registry-4.7-distribution-2461543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workload identity federation will enable short lived credentials in a gcp
cluster. Current version golang.org/x/oauth2 does not support it.
This PR also includes changes that gcp storage driver code to consume
new credentials
ref: https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity