Update disconnected asserts for RHOSDT 3.11 - #155
Conversation
The tempo-gateway-opa container's 8082 port is named opa-http, not
public. The assert still expected the old name and failed against the
RHOSDT 3.11 build:
spec.template.spec.containers[1].ports[0].name:
Invalid value: "opa-http": Expected value: "public"
The tempo-gateway container's own 8080 port is still named public and is
left untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The collector no longer emits without_scope_info, without_type_suffix and without_units under service.telemetry.metrics.readers, so the generated collector.yaml no longer contains them and the assert failed against the RHOSDT 3.11 build. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Comment |
|
@rubenvp8510: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreasgerstmayr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
2 participants
What
Update two
tests/e2e-disconnectedasserts that no longer match what RHOSDT 3.11 produces. Both are deliberate upstream changes, not product defects.multitenancy/01-assert.yaml— OPA port renamedgrafana/tempo-operator#1574 ("chore: fix noisy operator logs") renamed the
tempo-gateway-opacontainer's 8082 port frompublictoopa-http. Both containers in that pod previously exposed a port namedpublic— the gateway on 8080 and OPA on 8082 — and the duplicate name was producing warnings. The operator's own asserts were updated in grafana/tempo-operator#1598; this repo was not.The
tempo-gatewaycontainer's 8080 port is stillpublicand is left as is.monolithic-multitenancy-openshift/01-assert.yamlalso containsname: public, but for that same gateway port, and it passes — so it is not touched.smoke-targetallocator/00-assert.yaml— telemetry fields no longer emittedThe expected
collector.yamlstill contained:open-telemetry/opentelemetry-operator#5204 promoted the
operator.collector.usedefaulttelemetryshapefeature gate from Alpha to Beta. Beta gates default to on, so the operator-injected Prometheus telemetry reader now uses collector defaults and no longer writes those three keys. Part of the SIG plan tracked in open-telemetry/opentelemetry-operator#5075. Users who need the previous shape can opt out with--feature-gates=-operator.collector.usedefaulttelemetryshape.How this was found
Running the OCP 4.16 disconnected job against the 3.11 index images. The job had been failing before reaching the tests since June — see openshift/release#84710 — and once it got through, these two were the only failures:
🤖 Generated with Claude Code