feat(collector): promote operator.collector.usedefaulttelemetryshape gate to beta - #5204
Merged
swiatekm merged 3 commits intoJun 11, 2026
Conversation
❌ 18 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Beta promotion of operator.collector.usedefaulttelemetryshape sets without_type_suffix=true by default, so the collector's self-telemetry metrics no longer carry the _total counter suffix. Update the validate-collector-metrics and validate-collector-spans step templates to assert on the new names. Signed-off-by: nikhilmantri0902 <nikhil.mantri1999@gmail.com>
Contributor
Author
|
@swiatekm can you review this, its ready. |
swiatekm
reviewed
Jun 11, 2026
swiatekm
left a comment
Contributor
There was a problem hiding this comment.
The code changes look good to me, left some comments about the documentation.
| @@ -0,0 +1,17 @@ | |||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | |||
| change_type: enhancement | |||
Contributor
There was a problem hiding this comment.
This is a breaking change.
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | | ||
| Users wanting the pre-v0.152.0 metric name shape can disable the gate via --feature-gates=-operator.collector.usedefaulttelemetryshape, or pin without_type_suffix/without_units/without_scope_info to false explicitly under spec.config.service.telemetry. The gate will be promoted to stable and removed in a future release. |
Contributor
There was a problem hiding this comment.
From the users' perspective, this will take place in v0.154.0, so that's the version we should refer to. This comment applies to other bits of documentation in this PR too.
Address review on open-telemetry#5204: - chloggen change_type: enhancement -> breaking - replace pre-v0.152.0 with pre-v0.154.0 across chloggen subtext, featuregate description/comment, AddPrometheusMetricsEndpoint comment, and config_test comment (v0.152.0/v0.153.0 shipped with the alpha-off default, so the user-visible shape change actually lands in v0.154.0). Signed-off-by: nikhilmantri0902 <nikhil.mantri1999@gmail.com>
swiatekm
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Promotes the
operator.collector.usedefaulttelemetryshapefeature gate from Alpha to Beta. Beta gates default ON, so the operator-injected Prometheus telemetry reader now uses collectordefaults — metric names from operator-managed collectors no longer carry type suffixes, units, or scope_info.
AddPrometheusMetricsEndpointretains the gate check so users who need the pre-v0.152.0 metric name shape can opt out via--feature-gates=-operator.collector.usedefaulttelemetryshape, or pinwithout_type_suffix/without_units/without_scope_infotofalseexplicitly underspec.config.service.telemetry. The gate will be promoted to Stable and removed in a future release.This is the next step in the SIG plan from 2026-05-05 tracked in #5075.
Link to tracking Issue(s): #5075
Testing:
internal/otelconfig/config_test.go:TestAddPrometheusMetricsEndpointUsesCollectorDefaultsByDefault(no toggle, default behavior) andTestAddPrometheusMetricsEndpointPreservesShapeWhenGateDisabled(explicitly disables the gate via a new
withTelemetryShapeGatehelper).TestTelemetryLogsPreservedWithMetricsandTestTelemetryIncompleteConfigAppliesDefaultsto expect the 3 fields to be absent under the new default.internal/webhook/collector_webhook_test.go(TestCollectorDefaultingWebhook) andpkg/collector/upgrade/v0_122_0_test.go(TestUpgrade0_122_0/should_remove_address_field_from_metrics_config)to drop the 3 fields from their expected configs.
tests/e2e/*,tests/e2e-targetallocator*,tests/e2e-ta-collector-mtls,tests/e2e-openshift/must-gather) to drop the 3without_*: falselines.tests/e2e/versioned-configmaps/{00,01}-assert.yamlandtests/e2e-openshift/must-gather/assert-install-target-allocator.yamlfor the new rendered configbytes.
Verified locally:
go test ./...(45 packages, 0 failures) and./bin/chainsaw test --test-dir ./tests/e2e/versioned-configmaps→PASS.Documentation: Added a changelog entry at
.chloggen/feat_5075-promote-telemetry-shape-beta.yaml(enhancement,collector). The feature-gate'sWithRegisterDescriptionand the comment onAddPrometheusMetricsEndpointhave been updated to reflect the new default.