STOR-2586: Rebase to v4.10.0 for OCP 4.21 #89
Conversation
…bernetes-csi#662) * Populate VolumeError.ErrorCode field Signed-off-by: Eddie Torres <[email protected]> * Guard patching AttachError.ErrorCode behind MutableCSINodeAllocatableCount feature gate Signed-off-by: Eddie Torres <[email protected]> * Fix make test Signed-off-by: Eddie Torres <[email protected]> --------- Signed-off-by: Eddie Torres <[email protected]>
…-faster Restart external-attacher faster by releasing leader election lease on sigterm
Bumps the k8s-dependencies group with 2 updates in the / directory: [sigs.k8s.io/apiserver-network-proxy/konnectivity-client](https://github.com/kubernetes-sigs/apiserver-network-proxy) and [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml). Updates `sigs.k8s.io/apiserver-network-proxy/konnectivity-client` from 0.31.2 to 0.33.0 - [Release notes](https://github.com/kubernetes-sigs/apiserver-network-proxy/releases) - [Changelog](https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/apiserver-network-proxy@v0.31.2...v0.33.0) Updates `sigs.k8s.io/yaml` from 1.4.0 to 1.6.0 - [Release notes](https://github.com/kubernetes-sigs/yaml/releases) - [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/yaml@v1.4.0...v1.6.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/apiserver-network-proxy/konnectivity-client dependency-version: 0.33.0 dependency-type: indirect update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/yaml dependency-version: 1.6.0 dependency-type: indirect update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…go_modules/k8s-dependencies-9248c45c46 Bump the k8s-dependencies group across 1 directory with 2 updates
…ments fix comments in features.go
Strings are safe, because our existing keys were VA and PV names. Refresh go.mod with `GO111MODULE=on go mod tidy`.
Address various linter (staticcheck, modernize, etc.) comments.
Fix version of kubernetes for alpha version of ReleaseLeaderElectionOnExit fg
5f38a907 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f6242 Update go to 1.24.6 74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7 Update CSI prow driver version to v1.17.0 0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af10153 update to go 1.24.4 f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db Remove chrishenzie from kubernetes-csi-reviewers git-subtree-dir: release-tools git-subtree-split: 5f38a907597230563f5e2213aea116acdd9d86bc
…_k8s_1.34 Update release tools
Bump k8s dependencies to v1.34.0
Bump toolchain to go1.24.6 in go.mod
…-4.10 Add changelog for 4.10
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
jsafrane
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jsafrane: This pull request references STOR-2586 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@jsafrane: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
There is one customer-facing change that
After enable the feature-gate, we can get the TBH, I'm not pretty sure how the errorCode maps the CSI Driver error, but the population works anyway. |
|
After checking the code, it looks like only attach errorcode is populated, there is no detach errorcode. |
|
/verified by @duanwei33 |
openshift-ci-robot
added
the
verified
|
@duanwei33: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 344669a
into
openshift:master
13 participants
Summary
This PR rebases the OpenShift fork of external-attacher to upstream version v4.10.0 for OpenShift Container Platform 4.21.
Upstream Changelog
v4.10.0 Changes:
Previous version (v4.9.0):
Changes Applied
Verification
makecompleted without errorsUpstream Diff
View the diff between upstream v4.10.0 and this PR: kubernetes-csi/external-attacher@v4.10.0...jsafrane:csi-external-attacher:rebase-v4.10.0