Skip to content

Populate VolumeError.ErrorCode field in VolumeAttachment object#662

Merged
k8s-ci-robot merged 3 commits intokubernetes-csi:masterfrom
torredil:kadane-85123
Aug 1, 2025
Merged

Populate VolumeError.ErrorCode field in VolumeAttachment object#662
k8s-ci-robot merged 3 commits intokubernetes-csi:masterfrom
torredil:kadane-85123

Conversation

@torredil
Copy link
Copy Markdown
Member

@torredil torredil commented Jul 7, 2025

What type of PR is this?

/kind api-change

What this PR does / why we need it:

KEP-4876: Mutable CSINode Allocatable Property introduces a new field in the VolumeError struct used in the VolumeAttachment object Status field:

// Captures an error encountered during a volume operation.
type VolumeError struct {
  // errorCode is a numeric gRPC code representing the error encountered during Attach or Detach operations.
    ErrorCode *int32
}

This change populates the field when a plugin's ControllerPublishVolume RPC returns an error.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

See API strategy for the VolumeAttachment object here:

https://github.com/kubernetes/kubernetes/blob/ee012e883f863a141cab35e5a76cbe5d378ad36f/pkg/registry/storage/volumeattachment/strategy.go#L138

Does this PR introduce a user-facing change?:

Populate VolumeError.ErrorCode field in VolumeAttachment object.

Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jul 7, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2025
@torredil
Copy link
Copy Markdown
Member Author

torredil commented Jul 7, 2025

cc: @gnufied

Comment thread pkg/controller/csi_handler.go
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2025
@torredil
Copy link
Copy Markdown
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 29, 2025
Comment thread pkg/controller/csi_handler.go
…Count feature gate

Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 29, 2025
Signed-off-by: Eddie Torres <torredil@amazon.com>
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Aug 1, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 462cd54 into kubernetes-csi:master Aug 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants