Skip to content

Fix bug pipeline details page for Pipeline with no tasks throws error #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Sep 17, 2019
Merged

Fix bug pipeline details page for Pipeline with no tasks throws error #2724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
102ed58
Fix bug pipeline details page for Pipeline with no tasks throws error
vikram-raj Sep 16, 2019
288d7ad
change PipelineDetails component to FC
vikram-raj Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 31 additions & 24 deletions frontend/packages/dev-console/src/components/pipelines/PipelineDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,46 @@
import * as React from 'react';
import { SectionHeading, ResourceSummary, ResourceLink } from '@console/internal/components/utils';
import { referenceForModel } from '@console/internal/module/k8s';
import { referenceForModel, K8sResourceKind } from '@console/internal/module/k8s';
import { TaskModel } from '../../models';
import { PipelineVisualization } from './PipelineVisualization';

const PipelineDetails = ({ obj: pipeline }) => (
interface PipelineDetailsProps {
obj: K8sResourceKind;
}

const PipelineDetails: React.FC<PipelineDetailsProps> = ({ obj: pipeline }) => (
<div className="co-m-pane__body">
<SectionHeading text="Pipeline Overview" />
<PipelineVisualization pipeline={pipeline} />
<div className="row">
<div className="col-sm-6">
<ResourceSummary resource={pipeline} />
</div>
<div className="col-sm-6">
<SectionHeading text="Tasks" />
<dl>
{pipeline.spec.tasks.map((task) => {
return (
<React.Fragment key={task.name}>
<dt>Name: {task.name}</dt>
<dd>
Ref:{' '}
<ResourceLink
kind={referenceForModel(TaskModel)}
name={task.taskRef.name}
namespace={pipeline.metadata.namespace}
title={task.taskRef.name}
inline
/>
</dd>
</React.Fragment>
);
})}
</dl>
</div>
{pipeline.spec &&
(pipeline.spec.tasks && (
<div className="col-sm-6">
<SectionHeading text="Tasks" />
<dl>
{pipeline.spec.tasks.map((task) => {
return (
<React.Fragment key={task.name}>
<dt>Name: {task.name}</dt>
<dd>
Ref:{' '}
<ResourceLink
kind={referenceForModel(TaskModel)}
name={task.taskRef.name}
namespace={pipeline.metadata.namespace}
title={task.taskRef.name}
inline
/>
</dd>
</React.Fragment>
);
})}
</dl>
</div>
))}
</div>
</div>
);
Expand Down