Fix bug pipeline details page for Pipeline with no tasks throws error

[vikram-raj]

Fix bug - https://jira.coreos.com/browse/ODC-1858

[andrewballantyne]

@vikram-raj I think we probably want to drop that grey circle under the Overview header.

I think we probably want to explain why it doesn't have an overview, so maybe something like:

Will need UX for the verbiage (cc @serenamarie125 )

I am leaning towards thinking we should keep the title so there isn't just a void in "why don't I see the visualization on this pipeline?" kind of questions. Thoughts Serena?

[vikram-raj]

@andrewballantyne Agree, and there is a separate issue for that and we need confirmation from the issue. Once UX will confirm it then I will remove that.

[andrewballantyne]

pipeline.spec nor pipeline.spec.tasks are guaranteed by the type. Recommend handling the possible NPEs as well.

Also, could we get an explicit type on this variable - like type the FC?

[andrewballantyne]

In frontend/public/module/k8s/index.ts, this type is used for other components that this component calls.

export type K8sResourceKind = {
  apiVersion?: string;
  kind?: string;
  metadata?: ObjectMetadata;
  spec?: {
    selector?: Selector;
    [key: string]: any
  };
  status?: {[key: string]: any};
  type?: {[key: string]: any};
  data?: {[key: string]: any};
};

[vikram-raj]

@andrewballantyne Done.

[andrewballantyne]

Well, since the design stuff is tracked in another ticket - I'll just review the problem at hand... and that was a NPE breaking things. You fixed that, so I guess that's pretty much it for this PR.

/lgtm
/test e2e-aws-console

[vikram-raj]

@andrewballantyne Yeah, we get the input from the UX then I will fix the design issue as well.

[vikram-raj]

/assign @christianvogt

[christianvogt]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment