Skip to content

fix(fonts): don't copy overpass font to dist #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 26, 2019
Merged

fix(fonts): don't copy overpass font to dist #2681

openshift-merge-robot merged 1 commit into from
Sep 26, 2019

Conversation

@redallen
Copy link
Contributor

@redallen redallen commented Sep 11, 2019

Closes half of patternfly/patternfly#2245 . The other half needs to be docs on how to do this.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2019

Hi @redallen. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2019
@spadgett
Copy link
Member

spadgett commented Sep 11, 2019

/hold

depends on #2668

@spadgett spadgett added this to the v4.3 milestone Sep 11, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2019
@rhamilto
Copy link
Member

rhamilto commented Sep 11, 2019

@redallen, mind squashing your commits?

@redallen
Copy link
Contributor Author

redallen commented Sep 11, 2019

@rhamilto Done.

@spadgett spadgett changed the base branch from master to master-next September 17, 2019 13:12
@spadgett spadgett changed the base branch from master-next to master-4.3 September 17, 2019 13:13
@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2019
@rhamilto
Copy link
Member

rhamilto commented Sep 23, 2019

/retest

2 similar comments
@rhamilto
Copy link
Member

rhamilto commented Sep 23, 2019

/retest

@rhamilto
Copy link
Member

rhamilto commented Sep 23, 2019

/retest

@spadgett spadgett changed the base branch from master-4.3 to master September 26, 2019 14:37
@spadgett
Copy link
Member

spadgett commented Sep 26, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
spadgett
spadgett approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redallen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@rhamilto
Copy link
Member

rhamilto commented Sep 26, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 795b0c5 into openshift:master Sep 26, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2019 •
edited
Loading

@redallen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 1be6814 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@redallen @openshift-ci-robot @spadgett @rhamilto @openshift-merge-robot